-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add multi select inspector #1811
Conversation
/** | ||
* WordPress dependencies | ||
*/ | ||
import { __ } from 'i18n'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note with #2172, these need to be updated to prefix the dependencies with @wordpress/
. You will need to perform a rebase against the latest version of master and apply your changes:
git fetch origin
git rebase origin/master
43d4285
to
c8ec711
Compare
Rebased this one. @jasmussen So I guess instead of adding stuff to the sidebar, I'll try to keep the toolbar inline and offer the same block switcher and alignment options for multiple paragraphs. |
Codecov Report
@@ Coverage Diff @@
## master #1811 +/- ##
=========================================
- Coverage 34.07% 33.88% -0.2%
=========================================
Files 192 193 +1
Lines 5675 5711 +36
Branches 996 1006 +10
=========================================
+ Hits 1934 1935 +1
- Misses 3165 3190 +25
- Partials 576 586 +10
Continue to review full report at Codecov.
|
I also think we should remove the blue box on top entirely then. We can offer everything inline and more advanced things on the side. Would also be very nice on mobile with a "select" button to select multiple blocks. |
Love the idea behind this 🌟 🌟 🌟 🌟 🌟 Also agree with this:
I encountered a little flickering, though. Seemed to happen more often when the document tab was active. Tried to record a video: |
Strange, this should not affect the multi selection itself. Anyway, there's still some how left here. I'll move it inline. :) |
c8ec711
to
0769a4f
Compare
Redoing this whole thing so it's inline... WIP. Still need to add the formatting toolbar and allow the inspector to be the same for multi select. |
@mtias @aduth @youknowriad This is going to become quite messy if we keep the current API that is a single edit method returning an array and filling in slots. I would need to force the I see two solutions:
|
Okay, I'm going to split this up into two or three PR so we can move forward in the meantime with other improvements. |
@iseulde, can you confirm that this one is still relevant? |
Yes! I'll redo it a bit. |
Should this be closed since #3535 exists? |
I'm closing it in favor of #7635 which is more up to date. Let's iterate there. |
Actually, it's different than #7635. However, there is #3535 which is very similar and more up to date. In addition, we can easily reuse patterns which will come out of #7635 to apply to inspector controls, too as noted by @iseulde in this comment #7635 (comment) :) |
This is very much a WIP, but the idea is to add an inspector for multi-select as well. This could be useful for aligning multiple blocks at once, converting multiple paragraphs to a block quote or verse form...
Still needs some thinking around how the API would look like.