Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug fix Category Filter crash #20961

Closed
wants to merge 2 commits into from

Conversation

Ringish
Copy link
Contributor

@Ringish Ringish commented Mar 17, 2020

This PR solves the bug as described in #20915

@aduth aduth requested a review from draganescu March 17, 2020 21:06
@aduth aduth added [Block] Latest Posts Affects the Latest Posts Block [Type] Bug An existing feature does not function as intended labels Mar 17, 2020
@aduth
Copy link
Member

aduth commented Mar 17, 2020

I notice #20960 also aims to solve this. @draganescu @Ringish Preference on which to keep?

@draganescu
Copy link
Contributor

Hi @Ringish just for the sake of cleaning up the PR list, I will close this. in favor of #20960 as I have added a new commit that makes that PR work all right (this one still can't remove the last category in the list). Please, if you have the time, take #20960 for a spin and add your review on that one so we can push ahead. 🙏

@draganescu draganescu closed this Mar 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Latest Posts Affects the Latest Posts Block [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants