[Latest posts] Fixes the categories selector crash when category does not exist #20960
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
draganescu
requested review from
ajitbohra,
jorgefilipecosta,
Soean and
talldan
as code owners
|
Size Change: -291 B (0%) Total Size: 856 kB
ℹ️ View Unchanged
|
|
I notice #20961 also aims to solve this. @draganescu @Ringish Preference on which to keep? |
aduth
added
[Block] Latest Posts
|
@aduth thanks! :) we know, in a weird sync we both published the PRs at the same time. Well decide which is better. |
talldan
approved these changes
Mar 20, 2020
There was a problem hiding this comment.
Worked for me, though I did find the code a little hard to follow. I wondered if an early return like this might be more preferable at the start of the selectCategories function. Then the mapping function wouldn't have to worry about returning null:
const hasNoSuggestion = tokens.some(
( token ) => typeof token === 'string' && ! suggestions[ token ]
);
if ( hasNoSuggestion ) {
return;
}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes #20915
How has this been tested?
Tested locally by:
Types of changes
Non breaking changes to the LatestPosts edit component.
cc @Ringish