Make all same-document navigations sync #46
Conversation
This includes ones generated by intercepting the navigate event with event.respondWith(). However, the promise passed to event.respondWith() is still useful for signaling the navigation's successful or unsuccessful completion. That is used to fuel browser UI, such as the loading spinner, as well as promises and events. And a rejected promise passed to event.respondWith() will roll back the navigation. Closes #19. Closes #44.
| 1. `appHistory.current` updates. `appHistory.current.finished` is `false`. | ||
| 1. `currentchange` fires on `window.appHistory`. | ||
| 1. `appHistory.current` fires `navigateto`. | ||
| 1. Any now-unreachable `AppHistoryEntry` instances fire `dispose`. |
There was a problem hiding this comment.
for delayed failures, what happens to these "now-unreachable" Entries? should they become "reachable" again since the navigation was cancelled and appHistory.current was rolled back to its previous value?
There was a problem hiding this comment.
Great question.
I'm inclined to say that they're gone forever? Splicing a future history back into existence seems pretty weird. But in general the introduction of fallible single-page navigations raises a lot of questions, hmm...
There was a problem hiding this comment.
I'll open a dedicated issue about this and then point to it from here.
| 1. The URL bar updates to show `/foo`. | ||
| 1. Any loading spinner UI starts. | ||
|
|
||
| After the promise rejects in ten seconds: |
There was a problem hiding this comment.
should there be an additional entry in the list below about the appHistoryEvent.signal being aborted?
There was a problem hiding this comment.
I don't think so. The signal property is specifically for aborts. I.e., it's meant to indicate that something else aborted the navigation, not that the navigate handler completed the navigation with a failure.
This includes ones generated by intercepting the navigate event with event.respondWith(). However, the promise passed to event.respondWith() is still useful for signaling the navigation's successful or unsuccessful completion. That is used to fuel browser UI, such as the loading spinner, as well as promises and events. And a rejected promise passed to event.respondWith() will roll back the navigation.
Closes #19. Closes #44.