Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make all same-document navigations sync #46

Merged
merged 3 commits into from
Feb 25, 2021
Merged

Make all same-document navigations sync #46

merged 3 commits into from
Feb 25, 2021

Commits on Feb 25, 2021

  1. Make all same-document navigations sync 

    This includes ones generated by intercepting the navigate event with event.respondWith(). However, the promise passed to event.respondWith() is still useful for signaling the navigation's successful or unsuccessful completion. That is used to fuel browser UI, such as the loading spinner, as well as promises and events. And a rejected promise passed to event.respondWith() will roll back the navigation.

Closes #19. Closes #44.
    @domenic
    domenic committed Feb 25, 2021
    Configuration menu
    Copy the full SHA
    ca232c2 View commit details
    Browse the repository at this point in the history

  2. Note the discussion in 47

    @domenic
    domenic committed Feb 25, 2021
    Configuration menu
    Copy the full SHA
    f85958e View commit details
    Browse the repository at this point in the history

  3. Ack frehner

    @domenic
    domenic committed Feb 25, 2021
    Configuration menu
    Copy the full SHA
    b67a2ed View commit details
    Browse the repository at this point in the history