-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
currentchange is not suitable for measuring the time #59
Comments
A counter proposal I think would be a |
Was talking with someone and the confusion around the timing of Regarding a new event - would it just be easier to just add the timing information to |
Yeah, |
After #46,
appHistory.current
updates synchronously, and thuscurrentchange
fires synchronously, for all single-page navigations. So the example in the explainer which usescurrentchange
to measure the time is totally wrong.This should probably be solved together with #14 and #33 but I wanted to note it separately since it's a serious bug in the explainer.
The text was updated successfully, but these errors were encountered: