Dual boot solrizer #745
Merged
Dual boot solrizer #745
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Solrizer is deprecated so calling Solrizer.solr_name results in an error. ref: - https://github.com/samvera-deprecated/solrizer
ShanaLMoore
commented
Aug 9, 2023
| # app/helpers/solr_helper.rb | ||
| module SolrHelper | ||
| def solr_name(field_name, *opts) | ||
| if Module.const_defined?(:Solrizer) |
There was a problem hiding this comment.
I am not using the dual boot support #rails_5_1? helper method here because that wouldn't necessarily be a valid check.
|
Note: this branch is pointing to i54 instead of develop to show the diffs. Since i54's PR wasn't merged, I had to branch this work off of it. I intend to merge this branch into develop once i54 is approved. |
Solrizer is deprecated so calling Solrizer.solr_name results in an error. ref: - https://github.com/samvera-deprecated/solrizer
…into dual-boot-solrizer
orangewolf
previously approved these changes
Aug 9, 2023
kirkkwang
approved these changes
Aug 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is heavily influenced by the Bulkrax Solrizer solution.
related to:
Solrizer is deprecated so calling Solrizer.solr_name breaks for Hyrax 3+.
Now we are able to access the admin dashboard with dual boot. Previously it caused errors:
Rails 6.1:
BEFORE: