Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace solrizer reference so that feature works with hyrax 3+ #700

Merged
merged 2 commits into from
Jan 17, 2023

Conversation

bbpennel
Copy link
Contributor

Addresses:
#699

This change might not work with hyrax < 2.8, since it looks like solrizer got merged into activefedora in 12.0.0, so if we need to support those versions of hyrax we will likely need to add some logic in here to decide whether to use solrizer or activefedora.

I also suspect this code might not be getting fully tested, since bulkrax is using hyrax 3, but no tests seem to be impacted by this issue.

@bbpennel
Copy link
Contributor Author

I don't understand what the "PR has required labels" rule requires me to change?

Also wanted to make sure we are okay with the hyrax version requirement going up, as discussed above

@ShanaLMoore ShanaLMoore added the patch-ver for release notes label Jan 11, 2023
@ShanaLMoore
Copy link
Contributor

I don't understand what the "PR has required labels" rule requires me to change?

Also wanted to make sure we are okay with the hyrax version requirement going up, as discussed above

Bulkrax has the following requirement:

Error: Label check failed: required 1 of patch-ver, minor-ver, major-ver, ignore-for-release, but found 0.

@bbpennel
Copy link
Contributor Author

I've updated this PR to make it backwards compatible with older versions of hyrax. Could someone trigger the workflows again?

Copy link
Contributor

@bkiahstroud bkiahstroud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for making this change!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch-ver for release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants