Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge from development for production deployment #607

Merged
merged 9 commits into from
Aug 30, 2021
Merged

Merge from development for production deployment #607

merged 9 commits into from
Aug 30, 2021

Conversation

afred
Copy link
Contributor

@afred afred commented Aug 30, 2021

Includes PRs:

  1. 2265 Proxy Time Start Annotation #593 - Adds Proxy Start Time annotation type.
  2. 584 handle sony ci webhook #597 and Get Sony Ci ID from GUID via UI #604 - Adds Sony Ci integrations

jasoncorum and others added 9 commits July 8, 2021 13:24
* Adds SonyCi::WebhooksController#save_sony_ci_id which receives a webhook request from Sony Ci
  and finds an Asset based on the filename, and if found, saves the Sony Ci ID to the Asset.
* Logs webhook activity from Sony Ci in the sony_ci_webhook_logs table (model name SonyCi::WebhookLog).
  NOTE: Scaffolding was used to generate WebhookLog code. Any generated code that we will likely use soon
  was kept, the rest was not added to the git repo.

Closes #584.
* Updates sony_ci_api gem to use sony_ci_api_rewrite in github, branch v0.1.
	* Had to create a branch that was compatible with Faraday v0.17.x, b/c Hyrax dependencies
	  would not allow Faraday v1.3.
* Customizes Sony Ci ID input to include filename fetched from Sony Ci.
* Customizes Sony Ci ID input partial to include button that will populate Sony Ci ID
  entries from Sony Ci, where the filename matches a translated form of the Asset ID.
* Replaces old instances of SonyCiBasic with SonyCiApi::Client.
* Adds a SonyCi::APIController to wrap very specific requests to Sony Ci API using the
  new gem. Endpoints include:
  * /sony_ci/api/find_media&query={QUERY}&fields={FIELDS}
  	This will search the API for records matching {QUERY} and return JSON objects having properties
	specified by the comma-separated field list {FIELDS}
  * /sony_ci/api/get_filename&sony_ci_id={SONY_CI_ID}
    This will find the Sony Ci record and return a JSON object containing fields 'sony_ci_id' and 'name'.
* Handles SonyCiApi gem errors.

Closes #585.
…ting the PR.

* Updates Sony Ci gem with updated error handling.
* refactors error specs a bit to better guarantee we are ALWAYS returning JSON.
* Removes unused error class
* Tests error responses for controller action sony_ci/api/find_media
* Defines all routes under /sony_ci/* in the same place in routes.rb.
* Sets default format to JSON for routes under /sony_ci/api/*.
@afred afred merged commit 9d7d2ec into main Aug 30, 2021
orangewolf pushed a commit to notch8/ams that referenced this pull request Aug 30, 2022
Merge from `development` for production deployment
orangewolf pushed a commit to notch8/ams that referenced this pull request Aug 30, 2022
Merge from `development` for production deployment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants