584 handle sony ci webhook #597
Conversation
afred
force-pushed
the
585-handle-sony-ci-webhook
branch
from
b85c3b7
to
5d77d09
Compare
| respond_to do |format| | ||
| if @sony_ci_webhook_log.save | ||
| format.html { redirect_to @sony_ci_webhook_log, notice: 'Webhook log was successfully created.' } | ||
| format.json { render :show, status: :created, location: @sony_ci_webhook_log } |
There was a problem hiding this comment.
should this json output be rendering a template?
| respond_to do |format| | ||
| if @sony_ci_webhook_log.update(sony_ci_webhook_log_params) | ||
| format.html { redirect_to @sony_ci_webhook_log, notice: 'Webhook log was successfully updated.' } | ||
| format.json { render :show, status: :ok, location: @sony_ci_webhook_log } |
There was a problem hiding this comment.
Ack... i meant to get rid of all actions pertaining to WebhookLogs that were not #show or #index. The WebhgookLog records get created by virtue of Sony Ci sending requests to the /webhooks/[action] endpoint(s), so we don't currently have a use case for adding/editing/deleting the WebhookLog records directly. I'll fix this.
fwiw, you're correct, I think those actions responding with format.json will try to render a app/views/sony_ci/webhook_logs/[action].json.jbuilder, which is a ruby file that uses a ruby DSL to build JSON structures from ActiveRecord models. I believe I removed the tests for these controller actions, hence no errors on Travis.
all of this I learned yesterday after having used rails g scaffold ... which dumps a buuunch of files into your code.
afred
force-pushed
the
585-handle-sony-ci-webhook
branch
from
5d77d09
to
5f07820
Compare
* Adds SonyCi::WebhooksController#save_sony_ci_id which receives a webhook request from Sony Ci and finds an Asset based on the filename, and if found, saves the Sony Ci ID to the Asset. * Logs webhook activity from Sony Ci in the sony_ci_webhook_logs table (model name SonyCi::WebhookLog). NOTE: Scaffolding was used to generate WebhookLog code. Any generated code that we will likely use soon was kept, the rest was not added to the git repo. Closes #584.
afred
force-pushed
the
585-handle-sony-ci-webhook
branch
from
5f07820
to
90865c0
Compare
|
NOTE: the branch name beginning in |
|
and finally, in lieu of Travis buids... |
584 handle sony ci webhook
No description provided.