Get Sony Ci ID from GUID via UI #604
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Here's the screenshot of the passing specs from my local machine until we get CI up again. |
afred
force-pushed
the
585-sony-ci-id-from-asset
branch
10 times, most recently
from
a777ec6
to
d2bce49
Compare
* Updates sony_ci_api gem to use sony_ci_api_rewrite in github, branch v0.1.
* Had to create a branch that was compatible with Faraday v0.17.x, b/c Hyrax dependencies
would not allow Faraday v1.3.
* Customizes Sony Ci ID input to include filename fetched from Sony Ci.
* Customizes Sony Ci ID input partial to include button that will populate Sony Ci ID
entries from Sony Ci, where the filename matches a translated form of the Asset ID.
* Replaces old instances of SonyCiBasic with SonyCiApi::Client.
* Adds a SonyCi::APIController to wrap very specific requests to Sony Ci API using the
new gem. Endpoints include:
* /sony_ci/api/find_media&query={QUERY}&fields={FIELDS}
This will search the API for records matching {QUERY} and return JSON objects having properties
specified by the comma-separated field list {FIELDS}
* /sony_ci/api/get_filename&sony_ci_id={SONY_CI_ID}
This will find the Sony Ci record and return a JSON object containing fields 'sony_ci_id' and 'name'.
* Handles SonyCiApi gem errors.
Closes #585.
afred
force-pushed
the
585-sony-ci-id-from-asset
branch
from
b7a36b1
to
cae13a4
Compare
…ting the PR. * Updates Sony Ci gem with updated error handling. * refactors error specs a bit to better guarantee we are ALWAYS returning JSON. * Removes unused error class * Tests error responses for controller action sony_ci/api/find_media * Defines all routes under /sony_ci/* in the same place in routes.rb. * Sets default format to JSON for routes under /sony_ci/api/*.
afred
commented
Aug 25, 2021
|
@jasoncorum @foglabs this is ready for re-review. All conversations have been resolved. |
|
Here's the latest specs passing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
would not allow Faraday v1.3.
entries from Sony Ci, where the filename matches a translated form of the Asset ID.
new gem. Endpoints include:
This will search the API for records matching {QUERY} and return JSON objects having properties
specified by the comma-separated field list {FIELDS}
This will find the Sony Ci record and return a JSON object containing fields 'sony_ci_id' and 'name'.
NOTE: this PR hinges on the new version of the
sony_ci_apigem, which is currently being pulled from Github, branchv0.1. Reviewing the state of this branch should accompany this review: https://github.com/WGBH-MLA/sony_ci_api_rewrite/tree/v0.1Closes #585.