TEMPORARY BASE #65
Merged
TEMPORARY BASE #65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit bbe89b6.
…#63) * Update array function tracking * Update test * Clean up compiler output
* skip body extraction when the loop has 0 iterations * Modify interpreter to distinguish between circom functions and loop body functions * [VAN-676] duplicate extracted functions when flattening branch buckets * [VAN-670] generate and flatten subcmp counter/run * impl Debug for Env to be more friendly, expand on test case comment * remove debug println * fix: conditions not flattening in non-generated methods * [VAN-582] properly convert mapped to indexed when there are multiple versions of the subcomponent * fix XFAIL test outputs so they pass * add test cases * handle CallBucket return case in mapped_to_indexed * fix body_extractor assertion failure * fix segfault from improper GEP * use BucketId as key to speed up SimplificationPass * fix function name to reflect actual usage * Remove functions that cannot be reached from any template Co-authored-by: Daniel Dominguez <[email protected]>
…ing the functions (#55) * Refactor StoreBucket to avoid generating call to "llvm.donothing"
prevent "build" and "run" functions from different templates from merging but all others are open to merging
|
All of the commits with PR refs were already reviewed. So only the changes from the first 2 and last 1 commits have not already gone through review but they're minor: |
|
Do you want me to approve this or do you want to wait? Are we ready to merge back to |
Ready from my side. So whenever you guys are ready from the Vanguard side. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we're ready to update
llvmbranch, this should be added as a "rebase and merge" or "merge commit" to preserve the PR history.