Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[VAN-719] use LLVM pass to remove unused functions #64

Merged
merged 4 commits into from
Oct 31, 2023
Merged

[VAN-719] use LLVM pass to remove unused functions #64

merged 4 commits into from
Oct 31, 2023

Conversation

tim-hoffman
Copy link

No description provided.

@tim-hoffman tim-hoffman marked this pull request as draft October 24, 2023 19:23
Base automatically changed from th/benchmark-fixes to llvm-v2 October 30, 2023 22:30
@tim-hoffman tim-hoffman marked this pull request as ready for review October 31, 2023 02:27
0xddom
0xddom reviewed Oct 31, 2023
View reviewed changes
Copy link
Collaborator

@0xddom 0xddom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The fact that we don't use the main template's run function anywhere does not cause trouble with the DCE pass?

@tim-hoffman
Copy link
Author

The fact that we don't use the main template's run function anywhere does not cause trouble with the DCE pass?

I set the main template's "build" and "run" function with External linkage so they will not be removed. Everything else has Internal so it can be removed.

iangneal
iangneal approved these changes Oct 31, 2023
View reviewed changes
Copy link

@iangneal iangneal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM too

@tim-hoffman tim-hoffman merged commit 1931d22 into llvm-v2 Oct 31, 2023
4 checks passed
@tim-hoffman tim-hoffman deleted the th/van-719 branch October 31, 2023 19:23
tim-hoffman added a commit that referenced this pull request Oct 31, 2023
@tim-hoffman
[VAN-719] use LLVM pass to remove unused functions (#64)
1b12aff
tim-hoffman added a commit that referenced this pull request Nov 8, 2023
@tim-hoffman
[VAN-719] use LLVM pass to remove unused functions (#64)
959d5a0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iangneal iangneal iangneal approved these changes

@0xddom 0xddom 0xddom approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tim-hoffman @iangneal @0xddom