[VAN-676][VAN-670] flatten branches in extracted function by duplicating the functions #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tim-hoffman
force-pushed
the
th/van-676
branch
from
2d17366
to
6371cda
Compare
tim-hoffman
commented
Oct 18, 2023
circom/tests/subcmps/mapped.circom
Outdated
| @@ -41,3 +39,6 @@ template B(n) { | |||
| } | |||
|
|
|||
| component main = B(2); | |||
|
|
|||
| //TODO: This check is a filler just to capture when the test no longer crashes | |||
There was a problem hiding this comment.
Addressed in the next PR #56
tim-hoffman
commented
Oct 18, 2023
circom/tests/subcmps/mapped2.circom
Outdated
| @@ -57,3 +56,6 @@ template B(n, m, j) { | |||
| } | |||
|
|
|||
| component main = B(2, 3, 2); | |||
|
|
|||
| //TODO: This check is a filler just to capture when the test no longer crashes | |||
There was a problem hiding this comment.
Addressed in the next PR #56
iangneal
reviewed
Oct 30, 2023
circuit_passes/src/bucket_interpreter/env/extracted_func_env.rs
Outdated
Show resolved
Hide resolved
circuit_passes/src/bucket_interpreter/env/extracted_func_env.rs
Outdated
Show resolved
Hide resolved
tim-hoffman
added a commit
that referenced
this pull request
Oct 31, 2023
…ing the functions (#55) * Refactor StoreBucket to avoid generating call to "llvm.donothing"
tim-hoffman
added a commit
that referenced
this pull request
Nov 8, 2023
…ing the functions (#55) * Refactor StoreBucket to avoid generating call to "llvm.donothing"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this handles branches from circom source and branches generated to handle subcmp counter check for calling the subcmp "run" function