Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option for custom startup animations #355

Open
wants to merge 22 commits into
base: main
Choose a base branch
from

Conversation

ading2210
Copy link

@ading2210 ading2210 commented Jan 22, 2024

Based on feedback from #354, I've implemented a way to set a custom image on the splash window. The file is loaded from the user's filesystem, so no copyrighted assets are used.

image

vesktop_custom_splash-2024-01-22_23.45.06.mp4

This fixes issue #352 completely.

@ading2210
Copy link
Author

ading2210 commented Jan 24, 2024

I wouldn't recommend merging this at the moment, since it's currently broken under Windows. It's running into some issue reading the image file, and I haven't been able to do any testing.

@Vendicated Vendicated marked this pull request as draft January 24, 2024 07:11
@ading2210
Copy link
Author

Is anyone else able to test this on Windows? The person I had asked to test it before didn't rebuild the app properly. They rebuilt it today with the latest changes, and it's working now.

@ading2210 ading2210 marked this pull request as ready for review January 28, 2024 22:48
@jacksongoode
Copy link

Works for me 👍 definitely needed!

@Arian04
Copy link

Arian04 commented Mar 12, 2024

is there anything blocking the merging of this that I could help with? If you guys need another tester for this on Windows in addition to the two people above, I could try it out.

@ZirixCZ ZirixCZ mentioned this pull request Mar 13, 2024
@ading2210
Copy link
Author

@Vendicated

Now that all the merge conflicts are fixed (thanks to @sz6084), do you have any suggestions on how this PR can be improved? Considering the demand for this feature, hopefully we can get this merged as soon as possible.

src/main/index.ts Outdated Show resolved Hide resolved
@jmshgs

This comment was marked as spam.

@rklxmok

This comment was marked as spam.

@sz6084
Copy link

sz6084 commented May 20, 2024

Where are we at so I can use vencord without a furry?

You can technically build ading2210's repository from source by following the same steps as Vencord's repository but changing the URL for cloning to match:

git clone https://github.com/ading2210/Vesktop
cd Vesktop

# Install Dependencies
pnpm i

# Either run it without packaging
pnpm start

# Or package
pnpm package
# Or only build the pacman target
pnpm package --linux pacman
# Or package to a directory only
pnpm package:dir

@Covkie
Copy link
Collaborator

Covkie commented Jun 12, 2024

The ability to select multiple and have them picked at random would be nice as well.

@Covkie Covkie mentioned this pull request Jun 18, 2024
13 tasks
@tiagorangel1

This comment was marked as spam.

@jmshgs
Copy link

jmshgs commented Jun 24, 2024

ppl want more features in the pr for some reason :/
it seems great to me

@atriup

This comment was marked as spam.

@Vencord Vencord deleted a comment from henry9836 Jul 2, 2024
@tomma365
Copy link

using ading2210's repo works for the intended feature, (I can set custom splash screen) however my only issue with this repo is the go live screen doesnt let me select an audio source from a single application like the master branch does, I just get "Entire System" or "none", my understanding is that the custom splash feature is going to be merged with master branch, but i just wanted to see if anyone had a solution to this problem

@ading2210
Copy link
Author

I added a preview of the splash image to the Vesktop settings menu. This is an important requirement for loading the animation from the Vesktop cache, since displaying only the file path won't be possible with that approach.

vesktop_pr_1

I do eventually plan to implement all of the suggestions in #667, such as adding the ability to choose multiple images that are selected randomly and adding a toggle to turn off the splash screen entirely.

@FAArik

This comment was marked as spam.

@Covkie
Copy link
Collaborator

Covkie commented Jul 26, 2024

Error occurred in handler for 'VCD_SELECT_IMAGE_PATH': Error: ENOENT: no such file or directory, stat '/home/kylie/.config/vesktop/splash'

Seems youre not correctly creating the splash directory

@ading2210
Copy link
Author

@Covkie That error is fixed in the latest commit. It was happening because Vesktop was unconditionally trying to delete and remake the splash directory, even if it didn't exist before. Obviously this would have caused an error when it tried to remove a nonexistent directory, but it didn't happen in my previous testing because that directory was already there.

@lothar-cell
Copy link

Can't wait to get rid of the furry splash:)

@Vencord Vencord deleted a comment from stankovictab Aug 7, 2024
@LethalManBoob
Copy link

so when

@MMachado05
Copy link

MMachado05 commented Sep 25, 2024

Do you know if the way this has been implemented will support APNGs? They tend to be of better quality and of smaller filesize. Perhaps even AVIF or WebP. 😁

@ading2210
Copy link
Author

ading2210 commented Sep 25, 2024

@MMachado05 An <img> tag is used to load the animation, so APNG, AVIF, and WebP images should all work already.

@Fxzzi
Copy link

Fxzzi commented Oct 13, 2024

I've gone ahead and done some testing with this PR on linux. From what I can see, everything seems to work perfectly on my end. Imo, this is ready for merging but I'm not a maintainer soooo

@lewisakura
Copy link
Member

Has this been Flatpak tested?

@lothar-cell

This comment was marked as abuse.

@jmshgs

This comment has been minimized.

@lewisakura

This comment was marked as off-topic.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.