-
-
Notifications
You must be signed in to change notification settings - Fork 185
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
User customizable assets #667
Comments
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
About accent color, do you mean like the text selection color that comes from the system theme that gets applied on the browser (let's say, Firefox) to also apply for Vesktop (instead of it using dark blue text selection color due to Chromium's default)? Not sure where accent color would change much on Discord with the exception of text selection. I think Vesktop mantainers would prefer to stick with Discord official colors somehow. Also, FYI, there's custom icon themes that support the various states of Discord system tray (IIRC, system tray icon states work as expected on the official Discord client for Linux). Example of a custom theme that has support: Not sure how the implementation is going to be, but it would be nice to have an option/toggle like "Use system icons" which would use system-provided icon packs that have support for it (such as Papirus) - otherwise fall back to Vesktop's provided ones. If I'm not mistaken this is implemented by the DE, and (if I'm not mistaken) on KDE Plasma you can request a system icon with a simple call and get a returning value of it existing or not and then proceed from there. Not sure how it works on GNOME, but I think it's basically the same principle on GNOME and other DEs. |
Using the system accent colour is only meant for the tray. See #517 (Currently does not support Linux system accent). I dont think a toggle would be needed for relying on system provided or user provided tray icons as the system theme would just override the icons, no? |
Not sure. I think that by design Vesktop would prioritize its own icons and only search for system-provided icons if explicitly specified to do so (which a setting could do). |
This comment was marked as abuse.
This comment was marked as abuse.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as spam.
This comment was marked as spam.
Does this include customization of the window icon? To my knowledge, this is different from the tray icon. I'd like to customize the window icon because I'm used to scanning for the discord logo and Vesktop's square icon throws me off. |
I'd also like a "boring mode" option that reverts all of those assets to the Discord default ones. |
hasn't ven said that vesktop isn't going to redistribute discords icons |
Is there anything stopping the client from just... fetching them from Discord itself and then saving it? |
we can't use official discord icons. that would give Discord legal grounds to have Vencord taken down due to trademark infringement |
This comment was marked as spam.
This comment was marked as spam.
Would the Vencord logo with a circular purple background be legally distinct enough? For me, just a purple circle would be enough to manage without having to rewire my brain to look for a different logo. Could also include other background colours. |
I think it probably makes sense to move all the discussion on whether or not something is legal or not to a separate issue to avoid this cluttering this specific issue with unrelated stuff. This issue is specifically to allow user-provided assets. |
So is it possible to change the taskbar/notification area Icon to actually resemble Discord , or not? I'm confused. |
Yes it's possible to change the Vesktop application icon, on Linux. As follows:
What it does:
Here is an example with my own, custom icon. I have designed and included 18 different icon themes (54 icons total) in the repository for people who want to get started quickly. It will not change the notification area icon, since it's created by Vesktop itself (but that feature is coming to Vesktop later, as the 1st post in this thread explains): |
Could you open the issues tab in your repo? |
Alright, it's enabled, so you can make tickets. I don't want large feature requests though. :) |
So how do we actually change it? I've been starting at this page for a long time trying to figure out what to actually do. |
You can clone the repo, replace the icons with the official ones, and build it from source. I built it if you want to use my build files |
Perhaps it's best to move this conversation about an external tool to that tool's issue tracker, and leave this issue to the implementation of user customizable assets within Vesktop. That way, people won't get pinged for off-topic conversation. |
Yes, please do. If further discussion regarding third-party patching tools occurs I'll lock this issue and we'll work on it elsewhere. We shouldn't be promoting third-party patches because we can't provide support for them. |
Content
This is an issue which is meant to unify #571, #352 and #355, #439, #517, #576, #261 as well as #298, #424, #384, #294.
https://discord.com/channels/1015060230222131221/1216096162008924291/1252079440075161715
Design goals:
Scope:
Features:
Startup Splash:
(mostly implemented in Add option for custom startup animations #355)
#2
Tray icon:
Implemented in feat: Tray icon voice detection, customization and notification badge #517
FYI
System accent on linux is a standard portal. Read: flatpak/xdg-desktop-portal/pull/815. Try in your terminal:cc: @Vendicated @PolisanTheEasyNick @ading2210 @alchzh @MrGarlic1
The text was updated successfully, but these errors were encountered: