Finally added the submenu for changing the splash animation #589
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
new file: package-lock.json modified: src/main/index.ts modified: src/main/ipc.ts modified: src/main/splash.ts modified: src/preload/VesktopNative.ts
modified: src/shared/IpcEvents.ts Also testing if commit is verified or not.
modified: src/shared/settings.d.ts modified: static/views/splash.html
modified: src/renderer/components/settings/VencordLocationPicker.tsx
sz6084
changed the title
|
please do not change unrelated files |
Cynosphere
suggested changes
May 8, 2024
| <Forms.FormText> | ||
| The animation on the splash window is loaded from{" "} | ||
| {settings.splashAnimationPath ? ( | ||
| <a |
There was a problem hiding this comment.
Use Clickable (or Anchor if you want it to still look like a link) instead of an anchor tag.
| @@ -74,6 +74,10 @@ function init() { | |||
|
|
|||
| registerScreenShareHandler(); | |||
| registerMediaPermissionsHandler(); | |||
| //register file handler so we can load the custom splash animation from the user's filesystem | |||
| protocol.handle("splash-animation", () => { | |||
| return net.fetch("file:///"+splashAnimationPath); | |||
There was a problem hiding this comment.
Because it doesn't make sense to have a "network request" to grab a local file when you can just read it directly
Cynosphere's suggestions
|
The changes from this PR got added to #355 so this can be closed now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a sub-menu for custom splash animation.