-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release 2024.4.2 #321
Merged
Merged
Release 2024.4.2 #321
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Refactored the histogram into a new module, separating visualization code from the Vue-based user interface code and score-set-specific logic. - Implemented TypeScript for the heatmap and its interfaces. - Adopted D3.js data binding consistently for all SVG rendering, instead of removing DOM elements and re-creating them.
We may want to revisit the use of mavedb_label. Here we fall back to the variant's HGVS strings so that the score set histogram can be used in components that have not populated mavedb_label.
…fore the score set histogram's data are loaded.
…Dropdown Include the URN in the Experiment dropdown when creating score sets
During score set creation, we now only display active licenses to the user for selection. Because some score sets may have licenses selected which are no longer active, these licenses may be retained if they exist on a score set, but are un-selectable otherwise. Once a user updates a score set to get rid of such licenses, they will no longer be selectable. In addition, a new warning is displayed while editing such score sets so users are notified they are using a deprecated license.
…works for populateExperimentMetadata in dropdown.
…imentMetadata This is the original code.
Now that we handle this button state by asking the backend whether a user has permission for a certain action, it doesn't make sense to base the div component's visibility off the publication date of the experiment. Make the div visible always, and control the button visibility conditionally based on backend responses.
…ton-not-present-when-experiment-published Fixed: Edit Button not Appearing After Experiment Publication
…-target-category-constant Display Target Categories in a User Friendly Way
…ucleotide-heatmap Display a Nucleotide Heatmap for Non-Coding Score Sets
WebKit default behavior on OSX 10.7+ is to hide the scrollbar when not in use. This obscures the fact that the heatmap is a scrollable component.
…taset-metadata Expand Editable Score Set Metadata
…te-permitted-licenses Only Allow Users to Select from Active Licenses
…-autocompletion Limit “copy from existing target gene” to the user’s own target genes.
Utility Function for Refreshing Both Heatmaps at Once; Add Heatmap Functionality to Exclude Certain Datum from being Visible
…ated-zenodo-data-dump Update Zenodo Dataset Link
…le-chart-state Heatmap Refactor, Shareable Chart State, and Clinical Feature Feat Flag
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IMPORTANT: This release should also include an update of the preview site, whose features are now controlled by feature flags rather than diverging branches.
Features/Enhancements
Bug Fixes
Housekeeping