Fixed: Edit Button not Appearing After Experiment Publication #313
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now that we handle this button state by asking the backend whether a user has permission for a certain action, it doesn't make sense to base the div component's visibility off the publication date of the experiment. Make the div visible always, and control the button visibility conditionally based on backend responses.
bencap
added
type: bug
EstelleDa
approved these changes
Oct 30, 2024
bencap
deleted the
bugfix/bencap/312/edit-button-not-present-when-experiment-published
branch
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that we handle this button state by asking the backend whether a user has permission for a certain action, it doesn't make sense to base the div component's visibility off the publication date of the experiment. Make the div visible always, and control the button visibility conditionally based on backend responses.