-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use open-vsx.org as extension gallery #404
Conversation
Hi @spoenemann 👋 I'm so excited about this, thank you so much for opening this PR!! Can you help me understand a bit about how this works? I updated my product.json manually to use open-vsx to try it, and so far the experience is mostly seamless. I searched for In fact, including any extra links about motivation / how it works etc right in the README (like the links you have in the PR summary) would be great as well. I'm guessing because open-vsx is so new, it will be unfamiliar for most of the userbase. |
Hi @stripedpajamas! Open VSX is completely separate from the VS Code Marketplace, so you cannot expect all Marketplace extensions to be present in Open VSX. In fact there are currently only 218 extensions because the service is quite new and still in the process of being transferred to the Eclipse Foundation (the source code is already an Eclipse Foundation project, but the website is currently operated by TypeFox). The idea is to build a new community of extension developers and consumers and convince maintainers of popular extensions to publish to Open VSX in addition to the VS Code Marketplace. If someone is missing a particular extension, they should first approach the maintainers of that extension and ask to publish it to Open VSX. In case the maintainers won't do that, the fallback solution is to add an entry to A regression in user experience is inevitable. Building a new community takes time. I agree more documentation on this will be helpful. |
I updated README.md and DOCS.md, WDYT? |
Thanks for the clarification and the extra verbiage! Looks good to me. I'm super pumped about this initiative 😍 |
@stripedpajamas That is such an important change, can we get a new VSCodium release sooner than the next VSCode update? |
@GitMensch because of how things are setup currently, cutting a new VSCodium release would mean deleting the assets from the current release and triggering a new build. There are a bunch of downstream systems that will not react will well to that due to the new hashes. We don't currently have a way of releasing a version between VSCode versions. |
Thank you for the note, looks like this may be a good issue to track for "some later date" (seems useful to be independent from upcoming vscode releases, if necessary). |
If you'd like to chat more about this, feel free to share your thoughts at https://gitter.im/eclipse/openvsx |
@spoenemann Nice request, but what should I do with Russian language support? What to do with the support of programming languages? |
I've actually stumbled over the language stuff, too - I think it is best to ask Open VSX to auto-import it as it was done for other stuff .... if those extensions have a free license, which I did not recheck. |
@GitMensch Do you suggest that I come up to everyone and say "please build for OpenVSX too"? ok, but why doesn’t it work from VSIX? |
No, I've just set if you want to see it in the open vsx registry which is also what is searched in the vscodium extensions tab then it is likely best to ask the maintainer of the extension (or stand still and wait until others do).
I don't know what doesn't work for you but this definitely is quite a topic drift to this issue - you may want to create a new one after checking what the README and linked documentation says on this. |
oh, thanks |
VSCodium now uses open-vsx.org as its extension marketplace. - https://open-vsx.org/ - https://github.com/VSCodium/vscodium/blob/master/DOCS.md - VSCodium/vscodium#404 This commit will restructure extension lists to accommodate open-vsx. - marketplace-open-vsx.txt: extensions available on open-vsx.org - marketplace-proprietary.txt: closed-source extensions which can only be installed from the Microsoft marketplace on official VSCode builds - vsix-open.txt: extensions not listed on open-vsx.org, but for which downloadable VSIX files are available, either from releases in the source code repository, or by downloading from the extension page on https://marketplace.visualstudio.com/vscode - vsix-proprietary.txt: closed-source extensions installed from VSIX
VSCodium now uses open-vsx.org as its extension marketplace. - https://open-vsx.org/ - https://github.com/VSCodium/vscodium/blob/master/DOCS.md - VSCodium/vscodium#404 This commit will restructure extension lists to accommodate open-vsx. - marketplace-open-vsx.txt: extensions available on open-vsx.org - marketplace-proprietary.txt: closed-source extensions which can only be installed from the Microsoft marketplace on official VSCode builds - vsix-open.txt: extensions not listed on open-vsx.org, but for which downloadable VSIX files are available, either from releases in the source code repository, or by downloading from the extension page on https://marketplace.visualstudio.com/vscode - vsix-proprietary.txt: closed-source extensions installed from VSIX
Fixes #372.
The Microsoft Marketplace Terms of Use state
AFAICT VSCodium is not a "Visual Studio Product" and thus it may not use any "Marketplace Offerings". Strangely, the question whether the extensionsGallery setting can be used in forks (microsoft/vscode#31168) has been left unanswered for almost three years by the VS Code team. I wonder whether that's a deliberate decision to avoid annoying open source communities with legal issues. In any case, I think it's better to work around such issues and switch to an open source marketplace (see also git-for-windows/build-extra#278 (comment)).
Open VSX now has an adapter to the VS Code Marketplace API (eclipse/openvsx#55). I also added the
linkProtectionTrustedDomains
property to allow forwarding to the extension detail page on open-vsx.org when the user clicks on the name of an extension.See this article for more information on the motivation behind Open VSX.