Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use open-vsx.org as extension gallery #404

Merged
merged 1 commit into from
May 20, 2020

Conversation

spoenemann
Copy link
Contributor

Fixes #372.

The Microsoft Marketplace Terms of Use state

Marketplace Offerings are intended for use only with Visual Studio Products and Services and you may only install and use Marketplace Offerings with Visual Studio Products and Services.

AFAICT VSCodium is not a "Visual Studio Product" and thus it may not use any "Marketplace Offerings". Strangely, the question whether the extensionsGallery setting can be used in forks (microsoft/vscode#31168) has been left unanswered for almost three years by the VS Code team. I wonder whether that's a deliberate decision to avoid annoying open source communities with legal issues. In any case, I think it's better to work around such issues and switch to an open source marketplace (see also git-for-windows/build-extra#278 (comment)).

Open VSX now has an adapter to the VS Code Marketplace API (eclipse/openvsx#55). I also added the linkProtectionTrustedDomains property to allow forwarding to the extension detail page on open-vsx.org when the user clicks on the name of an extension.

See this article for more information on the motivation behind Open VSX.

@stripedpajamas
Copy link
Member

Hi @spoenemann 👋

I'm so excited about this, thank you so much for opening this PR!!

Can you help me understand a bit about how this works? I updated my product.json manually to use open-vsx to try it, and so far the experience is mostly seamless. I searched for javascript and found JavaScript extensions. I searched for ava and found no extensions, but I know there is an ava extension in the normal marketplace. Should users expect all VSCode Marketplace extensions to be present in open-vsx? If not, can you update the PR to make this clear in the README, and perhaps link to our DOCS.md for information about how to re-enable the default marketplace? I want to avoid a regression in user experience, especially given that a lot of users will receive this change automatically when their installation autoupdates (after we merge).

In fact, including any extra links about motivation / how it works etc right in the README (like the links you have in the PR summary) would be great as well. I'm guessing because open-vsx is so new, it will be unfamiliar for most of the userbase.

@spoenemann
Copy link
Contributor Author

Hi @stripedpajamas! Open VSX is completely separate from the VS Code Marketplace, so you cannot expect all Marketplace extensions to be present in Open VSX. In fact there are currently only 218 extensions because the service is quite new and still in the process of being transferred to the Eclipse Foundation (the source code is already an Eclipse Foundation project, but the website is currently operated by TypeFox).

The idea is to build a new community of extension developers and consumers and convince maintainers of popular extensions to publish to Open VSX in addition to the VS Code Marketplace. If someone is missing a particular extension, they should first approach the maintainers of that extension and ask to publish it to Open VSX. In case the maintainers won't do that, the fallback solution is to add an entry to extensions.json in open-vsx/publish-extensions. A GitHub action will then take care of publishing the extension.

A regression in user experience is inevitable. Building a new community takes time. I agree more documentation on this will be helpful.

@spoenemann
Copy link
Contributor Author

I updated README.md and DOCS.md, WDYT?

DOCS.md Outdated Show resolved Hide resolved
@stripedpajamas
Copy link
Member

Thanks for the clarification and the extra verbiage! Looks good to me. I'm super pumped about this initiative 😍

@stripedpajamas stripedpajamas merged commit d695216 into VSCodium:master May 20, 2020
@GitMensch
Copy link
Collaborator

@stripedpajamas That is such an important change, can we get a new VSCodium release sooner than the next VSCode update?

@stripedpajamas
Copy link
Member

@GitMensch because of how things are setup currently, cutting a new VSCodium release would mean deleting the assets from the current release and triggering a new build. There are a bunch of downstream systems that will not react will well to that due to the new hashes. We don't currently have a way of releasing a version between VSCode versions.

@GitMensch
Copy link
Collaborator

Thank you for the note, looks like this may be a good issue to track for "some later date" (seems useful to be independent from upcoming vscode releases, if necessary).

@spoenemann spoenemann deleted the open-vsx branch May 20, 2020 19:10
@spoenemann
Copy link
Contributor Author

If you'd like to chat more about this, feel free to share your thoughts at https://gitter.im/eclipse/openvsx

@rellikmil
Copy link

@spoenemann Nice request, but what should I do with Russian language support? What to do with the support of programming languages?

@GitMensch
Copy link
Collaborator

I've actually stumbled over the language stuff, too - I think it is best to ask Open VSX to auto-import it as it was done for other stuff .... if those extensions have a free license, which I did not recheck.
@den32ds For the support of programming languages: ask the maintainers of the extensions to co-publish on the open vsx registry, many will do this quite fast. Note: some plugins - especially the ones from Microsoft do not have a license that allows you to use it anywhere else then the "VSCode" binaries created by Microsoft.

@rellikmil
Copy link

@GitMensch Do you suggest that I come up to everyone and say "please build for OpenVSX too"? ok, but why doesn’t it work from VSIX?

@GitMensch
Copy link
Collaborator

Do you suggest that I come up to everyone and say "please build for OpenVSX too"?

No, I've just set if you want to see it in the open vsx registry which is also what is searched in the vscodium extensions tab then it is likely best to ask the maintainer of the extension (or stand still and wait until others do).
You can of course manually download and install the extensions - most will work.

but why doesn’t it work from VSIX?

I don't know what doesn't work for you but this definitely is quite a topic drift to this issue - you may want to create a new one after checking what the README and linked documentation says on this.

@rellikmil
Copy link

I don't know what doesn't work for you but this definitely is quite a topic drift to this issue - you may want to create a new one after checking what the README and linked documentation says on this.

oh, thanks

br3ndonland added a commit to br3ndonland/dotfiles that referenced this pull request Jul 3, 2020
VSCodium now uses open-vsx.org as its extension marketplace.

- https://open-vsx.org/
- https://github.com/VSCodium/vscodium/blob/master/DOCS.md
- VSCodium/vscodium#404

This commit will restructure extension lists to accommodate open-vsx.

- marketplace-open-vsx.txt: extensions available on open-vsx.org
- marketplace-proprietary.txt: closed-source extensions which can only
  be installed from the Microsoft marketplace on official VSCode builds
- vsix-open.txt: extensions not listed on open-vsx.org, but for which
  downloadable VSIX files are available, either from releases in the
  source code repository, or by downloading from the extension page on
  https://marketplace.visualstudio.com/vscode
- vsix-proprietary.txt: closed-source extensions installed from VSIX
br3ndonland added a commit to br3ndonland/dotfiles that referenced this pull request Nov 6, 2020
VSCodium now uses open-vsx.org as its extension marketplace.

- https://open-vsx.org/
- https://github.com/VSCodium/vscodium/blob/master/DOCS.md
- VSCodium/vscodium#404

This commit will restructure extension lists to accommodate open-vsx.

- marketplace-open-vsx.txt: extensions available on open-vsx.org
- marketplace-proprietary.txt: closed-source extensions which can only
  be installed from the Microsoft marketplace on official VSCode builds
- vsix-open.txt: extensions not listed on open-vsx.org, but for which
  downloadable VSIX files are available, either from releases in the
  source code repository, or by downloading from the extension page on
  https://marketplace.visualstudio.com/vscode
- vsix-proprietary.txt: closed-source extensions installed from VSIX
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Integrate with Open VSX Registry
5 participants