-
Notifications
You must be signed in to change notification settings - Fork 29.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Can I put the extensionsGallery on my vscode fork? #31168
Comments
Since b00945f was committed under the MIT license, I would argue that you can redistribute any changes from it under a MIT compatible license. While you cannot copy from the "extensionsGallery": {
"serviceUrl": "https://marketplace.visualstudio.com/_apis/public/gallery",
"cacheUrl": "https://vscode.blob.core.windows.net/gallery/index",
"itemUrl": "https://marketplace.visualstudio.com/items"
} Being new to the project and conscious of Free Software licenses, I have never downloaded the propitiatory product, agreed to the license nor read any of the propitiatory code. My only knowledge of the above code comes through b00945f and this issue. I am not a lawyer and this is not legal advice. |
A question on the cacheURL: https://vscode.blob.core.windows.net/gallery/index It looks like it hasn't been updated since March 2017. The most recent "lastUpdated" date is 2017-03. |
Based on this comment, the answer is yes? |
Even if it wasn't licensed, the code in question is so tiny and generic (it's literally a few labels and web addresses) that I would question whether it's even copyrightable in the first place. |
@chrisdias any legal update? |
Acknowledging some public URLs and copying them into the settings file of your own product isn't a copyright infringement at all. |
@ivanslf its not just about copying the lines, the terms of use for the vs code marketplace state that it can only be used with visual studio products. It's not clear whether that includes forks. |
This exists now http://open-vsx.org/ Extensions for VS Code Compatible Editors
|
@nhooyr @rrmckinley I wasn't aware of that, thanks. For ethical reasons, I'm uninstalling VSCode immediately in favor of Theia.
|
@ivanfilhoz It was announced today so very few people were aware. eclipse-theia/theia#7072 If you get the chance, I'd love to hear your first impressions of Theia 1.0, thanks I've created a feature request for the VSCodium project which would allow this on plain Code and not just Theia VSCodium/vscodium#372 |
@ivanfilhoz Theia is not an editor/IDE, but a framework for building IDEs. There's no generic Theia-based application that you could download at the moment. But of course anyone is free to start a new project using Theia to build an Electron app that mimics VS Code. |
Hey @chrisdias, I believe you can close this now, unless you want to officially contradict the analysis in my prior comment. |
as far as I know, if you HAVE vscode, you can use the marketplace BUT not distribute it |
Hm, this is still open, not resolved...
So that does contradict to @toddewilliams analysis. As vscode is the only OSS the list could easily be adjusted to read; -Visual Studio Code, GitHub Codespaces, Azure DevOps, Azure DevOps Server, and successor products and services
+Visual Studio Code and derivatives thereof, GitHub Codespaces, Azure DevOps, Azure DevOps Server, and successor products and services ... it may be good to update the marketplace TOU as the use is said to be only valid
where does accessing it with the browser instead of the APIs fit there? |
@chrisdias is not in a position to speak for Microsoft and was likely told he overstepped his role in his prior comment. That is why he has not commented further. And while it is true that you can configure project.json to point to the official marketplace that doesn't mean you may (ie. you legally are permitted to do it). Licenses tell you what you are legally permitted to do and they are very clear on this point; I stand by my prior analysis, above. Microsoft benefits from not answering this question directly as the only answer is to admit that you are not permitted to use the their official marketplace in anything that isn't a Microsoft product. They don't want to do that for obvious reasons. I continue to invite an actual representative of Microsoft to contradict my prior analysis and close this issue if I've made any errors in the interpretation of their licenses. |
By default the https://github.com/Microsoft/vscode does not come with key:
on its https://github.com/Microsoft/vscode/blob/master/product.json file. That entry is required to install extensions from the marketplace as showed on:
Also there is this commits, where their developer putted the key:
But sequentially removed it justifying:
Why they are removing it? Seems they are using it while developing, as we may see he let slip the line to the upper stream. Can I put it on my fork? Or I can only use it locally as they seem to be doing?
Related issues:
The text was updated successfully, but these errors were encountered: