$ORT_ALLOW_VERBOSE_LOGGING_ON_RELEASEを導入
#10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qryxip
commented
Dec 7, 2022
Comment on lines
-275
to
+305
| Level::TRACE, | ||
| "onnxruntime", | ||
| category = category.to_str().unwrap_or("<unknown>"), | ||
| file = code_location.file, | ||
| line_number = code_location.line_number, | ||
| function = code_location.function, | ||
| logid = logid.to_str().unwrap_or("<unknown>"), | ||
| ); | ||
| let _enter = span.enter(); | ||
| let _span = cfg!(allow_verbose_logging).then(|| { | ||
| span!( | ||
| Level::TRACE, | ||
| "onnxruntime", | ||
| category = category.to_str().unwrap_or("<unknown>"), | ||
| file = code_location.file, | ||
| line_number = code_location.line_number, | ||
| function = code_location.function, | ||
| logid = logid.to_str().unwrap_or("<unknown>"), | ||
| ) | ||
| .entered() | ||
| }); |
There was a problem hiding this comment.
これについては完全に無害だとは思うが、挙動の一貫性のためこうしておいた。
There was a problem hiding this comment.
ここにおける"span"は、このonnxruntime{…}の中。
2022-12-07T14:39:09.569061Z INFO onnxruntime{category="onnxruntime" file="graph.cc" line_number="3559" function="CleanUnusedInitializersAndNodeArgs" logid=""}: onnxruntime::onnxruntime: "Removing initializer \'664\'. It is not used by any node and should be removed from the model."
2022-12-07T14:39:09.569084Z INFO onnxruntime{category="onnxruntime" file="graph.cc" line_number="3559" function="CleanUnusedInitializersAndNodeArgs" logid=""}: onnxruntime::onnxruntime: "Removing initializer \'661\'. It is not used by any node and should be removed from the model."
2022-12-07T14:39:09.569096Z INFO onnxruntime{category="onnxruntime" file="graph.cc" line_number="3559" function="CleanUnusedInitializersAndNodeArgs" logid=""}: onnxruntime::onnxruntime: "Removing initializer \'660\'. It is not used by any node and should be removed from the model."There was a problem hiding this comment.
(あとallow_debug_loggingのつもりでallow_verbose_loggingと書いていたので修正しました)
やっぱりallow_verbose_loggingの方が適切だと思ったのでそうしました。
| @@ -145,6 +145,26 @@ macro_rules! extern_system_fn { | |||
| ($(#[$meta:meta])* $vis:vis unsafe fn $($tt:tt)*) => ($(#[$meta])* $vis unsafe extern "C" fn $($tt)*); | |||
| } | |||
|
|
|||
| // textual scopeで`trace!`と`debug!`を宣言することにより、`tracing`のそれらの`use`を封じる | |||
There was a problem hiding this comment.
textual scopeについての解説はこれ。
Textual Scope - Macros By Example - The Rust Reference
私も思い付きで試してみるまで知らなかったが、下のmodやブロックにおける名前解決も邪魔できる。
qryxip
commented
Dec 7, 2022
qryxip
changed the title
$ORT_ALLOW_DEBUG_LOGGINGを導入$ORT_ALLOW_VERBOSE_LOGGING_ON_RELEASEを導入
Hiroshiba
approved these changes
Dec 26, 2022
qryxip
added a commit
to qryxip/ort
that referenced
this pull request
Jan 21, 2024
qryxip
added a commit
to qryxip/ort
that referenced
this pull request
Jan 23, 2024
This reverts commit f00ab54.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
VOICEVOX/voicevox_core#338 におけるログにポインタ値等を出せてしまう問題に対し、tracingについてはDEBUG、ORT本体についてはINFO以下の出力を制限することで解決します。
(tracingとORTのログレベルの対応はこんな感じになっているのでややこしいですが)