Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
$ORT_ALLOW_VERBOSE_LOGGING_ON_RELEASE
を導入 #10$ORT_ALLOW_VERBOSE_LOGGING_ON_RELEASE
を導入 #10Changes from 2 commits
ab31e0a
c3a030a
930edce
ba80c08
a8ac684
506d30a
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
textual scopeについての解説はこれ。
Textual Scope - Macros By Example - The Rust Reference
私も思い付きで試してみるまで知らなかったが、下の
mod
やブロックにおける名前解決も邪魔できる。There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
これについては完全に無害だとは思うが、挙動の一貫性のためこうしておいた。
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ここにおける"span"は、この
onnxruntime{…}
の中。There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(あとallow_debug_logging
のつもりでallow_verbose_logging
と書いていたので修正しました)やっぱり
allow_verbose_logging
の方が適切だと思ったのでそうしました。