Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#[tracing::instrument]をすべて消し飛ばす #8

Closed
wants to merge 1 commit into from

Conversation

qryxip
Copy link
Member

@qryxip qryxip commented Dec 4, 2022

VOICEVOX/voicevox_core#338 (comment) の対応として、find ./onnxruntime -name '*.rs' -exec sed -i '/#\[tracing::instrument\]/d' {} +します。

`find ./onnxruntime -name '*.rs' -exec sed -i '/#\[tracing::instrument\]/d' {} +`
Copy link
Member

@Hiroshiba Hiroshiba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

今存在を認識したのですが、tracing::instrument、便利ですね。

@qryxip
Copy link
Member Author

qryxip commented Dec 4, 2022

今考えたのですが、ログに出るような型だけDebug実装の側をどうにかするという手もあるかもしれません。

-1970-01-01T00:00:00.000000Z DEBUG drop{self=OrtOwnedTensor { tensor_ptr: 0x555af376a760, array_view: [0.93785167, 0.063058704, 0.08937682, 0.047547057, 0.07596417, 0.053706698, 0.10348523, 0.06311223, 0.07596652, 0.038565055, 0.050694168, 0.06685759, 0.0753997, 0.058399618, 0.09201351, 0.08852549, 0.1281984, 0.7167318], shape=[18], strides=[1], layout=CFcf (0xf), dynamic ndim=1, memory_info: MemoryInfo { ptr: 0x555aed871730 } }}: onnxruntime::tensor::ort_owned_tensor: Dropping OrtOwnedTensor.
+1970-01-01T00:00:00.000000Z DEBUG drop{self=OrtOwnedTensor { .. }}: onnxruntime::tensor::ort_owned_tensor: Dropping OrtOwnedTensor.

@qryxip
Copy link
Member Author

qryxip commented Dec 7, 2022

#10 の方がいいと思うので、こちらはいったんcloseします。

@qryxip qryxip closed this Dec 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants