Make refactor #164
Closed
Make refactor #164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I was wrong about Is there good reason not to map each unpaired fastq file separately and compile them after the mapping? |
| sangers = filter(is_sanger, files) | ||
| def convert_file(fn): | ||
| reads = list(SeqIO.parse(fn, 'fastq')) | ||
| os.remove(fn) |
There was a problem hiding this comment.
If an exception is raised in this block you will lose the file
…into make-refactor Conflicts: plan.md play/Makefile
|
no one wanted you :( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see discussion in #156 #155 #152
The current plan is to use jinja templating