Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Next release #70

Merged
merged 122 commits into from
Jan 4, 2016
Merged

Next release #70

merged 122 commits into from
Jan 4, 2016

Conversation

averagehat
Copy link
Contributor

ctleptop.py needs documentation

@necrolyte2
Copy link
Member

Talking to @mmelendrez we should probably include information about the CDS
So for our example, the CDS starts at position 84 and ends at 10262

These numbers can be automatically fetched from genbank info from the record.type == 'CDS'
For csv/tab files we would need user to supply them manually via options or possibly some meta data way inside the csv

@necrolyte2
Copy link
Member

@averagehat I'm not sure yet how this coding region will affect degen.py
Tests pass, but I didn't really do anything with the cds info

File Should Not Be Empty ${actual}
${actual_contents} = Get File ${actual}
${expected_contents} = Get File ${expected}
Should Be Not Equal As Strings ${expected_contents} ${actual_contents}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know how to tell pybot to check that all lines have NON-CODING

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You will have to change the expected output (file tests/testinput/ctl_expected.tsv)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All we need to do is ensure every line has noncoding in them. Seems like there should be a more dynamic way.

Like grep for non coding. Then wc the results and make sure same amount of lines as there are in file

@averagehat
Copy link
Contributor Author

I have added the plot_muts script directly to this branch. It worked for the examples Irina gave me. I would like to make the plot a bit prettier at some point, plots still look like what's shown in #64 (but without the interval)

@necrolyte2
Copy link
Member

Can we add a test dataset into tests/testinput so we can put it into the documentation for people to use

@necrolyte2
Copy link
Member

Are we going to wait until poisson is finished or should we attempt to proceed with release cycle

@averagehat
Copy link
Contributor Author

@necrolyte2 I would suggest releasing this separately there is already a lot of stuff in it. It will be easier to look at a fresh diff as well.

@averagehat
Copy link
Contributor Author

Also the plot_muts script is functional in the terms we had planned for this release. So expanding that functionality makes sense as a smaller version bump

@necrolyte2
Copy link
Member

Shell we begin the merging/renaming procedure? I'll let you merge( @averagehat )

averagehat added a commit that referenced this pull request Jan 4, 2016
@averagehat averagehat merged commit 5316608 into master Jan 4, 2016
@necrolyte2 necrolyte2 mentioned this pull request Jan 4, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants