bug(perf): auto-theme performance regression

[Rudxain]

Describe the bug

#531, more specifically this commit 76aba1e (according to git bisect), causes the entire UI to become sluggish on a Dell Inspiron 15R.

IDK exact perf, but I guess previous commit (5f43725) is ~60FPS and the one I referenced is ~1FPS (no device connected) or ~0.5FPS (when the list of installed packs has been fetched)

Expected behavior

UAD-NG must have smooth performance while idle

You have a solution?

I suspect Iced is somehow calling dark_light::detect every frame 💀 (possibly our fault).

If we upgrade to the new Iced (and ditch our implementation), then the dark_light integration should work properly as-is

Operating System

Linux

Distro version

Debian 13

Window System + Manager

Wayland + Mutter

Desktop Environment

GNOME 46 (some apps are v47)

Provide logs

This may be irrelevant:

2024-09-24 13:34:41 WARN  [/home/rudxain/.cargo/registry/src/index.crates.io-6f17d22bba15001f/wgpu-hal-0.19.4/src/vulkan/instance.rs:696] InstanceFlags::VALIDATION requested, but unable to find layer: VK_LAYER_KHRONOS_validation
MESA-INTEL: warning: Ivy Bridge Vulkan support is incomplete
2024-09-24 13:34:41 WARN  [/home/rudxain/.cargo/registry/src/index.crates.io-6f17d22bba15001f/wgpu-hal-0.19.4/src/vulkan/adapter.rs:1143] Adapter is not Vulkan compliant, hiding adapter: Intel(R) HD Graphics 4000 (IVB GT2)

Acknowledgements

• This issue is not a duplicate of an existing bug report.
• I have chosen an appropriate title.
• All requested information has been provided properly.

[neingeist]

This makes the UI very slow, btw!

[Rudxain]

I've confirmed that if the user selects any theme other than "Auto", the UI performance is fast.

Being optimistic, this means there's a workaround for users who don't want to await the next release (minor or hotfix patch). The feature is broken anyways (#627), so I doubt most people would use it as-is 🥲

[neingeist]

I've confirmed that if the user selects any theme other than "Auto", the UI performance is fast.

This workaround also works for me ⚡

[Rudxain]

I doubt most people would use it

I was wrong. It's the default setting:

universal-android-debloater-next-generation/src/core/theme.rs

Lines 7 to 9 in c3fe1a4

	#[default]
	/// `Dark` or `Light`, according to `dark_light`
	Auto,

We should fix this ASAP

[AnonymousWP]

I doubt most people would use it

I was wrong. It's the default setting:

universal-android-debloater-next-generation/src/core/theme.rs

Lines 7 to 9 in c3fe1a4

	#[default]
	/// `Dark` or `Light`, according to `dark_light`
	Auto,

We should fix this ASAP

Is it an easy fix?

[ZMJGMADHPXWT]

Workaround works well, thank you for help!

[Rudxain]

Is it an easy fix?

Sure! we can simply move the attribute to Dark (as per #540)

But the config file on some users' devices will still be set to "Auto". So UADNG should deem Auto as invalid (as if the theme didn't exist) and fall-back to Dark

[Rudxain]

Iced is somehow calling dark_light::detect

Found the culprit (search palette() to see the horror 💀)

Who assigned to p and then forgot to use it literally 4 lines later? 😭

universal-android-debloater-next-generation/src/gui/style.rs

Lines 103 to 107 in 47980f6

	let p = self.palette();
	let appearance = button::Appearance {
	border: Border {
	color: self.palette().normal.primary,

[Rudxain]

I'm already working on using static_init to cache dark_light on startup. This should fix the perf problem and patch (not a real fix) #550 !

[AnonymousWP]

Great work!