Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: follow system theme #182

Closed
ghost opened this issue Jan 20, 2024 · 4 comments · Fixed by #531 or #702
Closed

feat: follow system theme #182

ghost opened this issue Jan 20, 2024 · 4 comments · Fixed by #531 or #702
Labels
enhancement New feature or request
Milestone

Comments

@ghost
Copy link

ghost commented Jan 20, 2024

just sync it with the os 🥴

@ghost ghost added the enhancement New feature or request label Jan 20, 2024
@AnonymousWP
Copy link
Member

This should be an option; not the default.

@AnonymousWP AnonymousWP changed the title dark theme or light theme? feat: follow system theme Feb 7, 2024
@AnonymousWP AnonymousWP added this to the v1.1.0 release milestone Mar 19, 2024
@Rudxain
Copy link
Member

Rudxain commented Jul 4, 2024

I'm willing to contribute to this. However, I'm still trying to get familiarized with the codebase.

dark-light doesn't provide async API, so color-scheme can only be efficiently synced on app startup. We could poll dark_light::detect to update in real-time, but that seems overkill since most users won't frequently change the DE theme while UAD is running. Maybe we could update on other events such as window-focus?

In the future, we could copy some code from Firefox (is MPL-2.0 compatible with GPL-3.0?), to update in real-time in an event-driven way

@AnonymousWP
Copy link
Member

It's fine if it's only on start-up. If it's not too much work it's a nice bonus, but not mandatory for sure.🙂

@Rudxain
Copy link
Member

Rudxain commented Oct 27, 2024

#650 #627

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
2 participants