Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug(theme): Auto always Light (regression) #627

Closed
3 tasks done
Rudxain opened this issue Sep 16, 2024 · 5 comments · Fixed by #702
Closed
3 tasks done

bug(theme): Auto always Light (regression) #627

Rudxain opened this issue Sep 16, 2024 · 5 comments · Fixed by #702
Labels
bug Something isn't working UI Related to the UI
Milestone
v1.1.1

Comments

@Rudxain
Copy link
Member

Rudxain commented Sep 16, 2024 •
edited
Loading

Describe the bug

dark-light v1.1.1 falls-back to Light unconditionally

I've been debugging this and I am 100% certain this is a bug in dark_light::detect

Expected behavior

Theme should be detected properly

You have a solution?

We could downgrade to v=1.0.0, until it's fixed upstream

Operating System

Linux

Distro version

Debian 13

Window System + Manager

Wayland + Mutter

Desktop Environment

GNOME 46

Provide logs

Irrelevant

Acknowledgements

  • This issue is not a duplicate of an existing bug report.
  • I have chosen an appropriate title.
  • All requested information has been provided properly.
@Rudxain Rudxain added bug Something isn't working UI Related to the UI labels Sep 16, 2024
@Rudxain Rudxain changed the title bug(theme): dark-light v1.1.1 falls-back to Light bug(theme): dark-light v1.1.1 falls-back to Light (regression) Sep 16, 2024
@Rudxain Rudxain mentioned this issue Sep 16, 2024
Open
@sgse

This comment was marked as off-topic.

Sign in to view
@Rudxain

This comment was marked as off-topic.

Sign in to view
@Frigyes06
Copy link
Member

Cannot reproduce on Arch Plasma/kwin with Wayland

@Frigyes06
Copy link
Member

Wait I might be dumb, what do you mean by fall back to? Can you provide steps to reproduce?

@Rudxain
Copy link
Member Author

Rudxain commented Sep 19, 2024

According to frewsxcv/rust-dark-light#21, the code returns Light instead of Default when it fails to detect color-scheme. I know it fails on my system, because it always returns Light regardless of my GNOME theme

@Rudxain Rudxain changed the title bug(theme): dark-light v1.1.1 falls-back to Light (regression) bug(theme): always Light (regression) Sep 19, 2024
@Rudxain Rudxain changed the title bug(theme): always Light (regression) bug(theme): Auto always Light (regression) Sep 19, 2024
@Rudxain Rudxain mentioned this issue Sep 25, 2024
Closed
3 tasks
This was referenced Oct 27, 2024
Closed
Merged
@AnonymousWP AnonymousWP added this to the v1.1.1 milestone Oct 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working UI Related to the UI
Projects
None yet
Milestone
v1.1.1
4 participants
@sgse @AnonymousWP @Frigyes06 @Rudxain