Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support Numpy.ndArray for Node 2D/3D Coordinate Conversion Functions #346

Closed
hongyuchen1030 opened this issue Jun 14, 2023 · 0 comments · Fixed by #748
Closed

Support Numpy.ndArray for Node 2D/3D Coordinate Conversion Functions #346

hongyuchen1030 opened this issue Jun 14, 2023 · 0 comments · Fixed by #748
Assignees
@rajeeja @philipc2 @hongyuchen1030
Labels
dependencies Pull requests that update a dependency file improvement Improvements on existing features or infrastructure
Milestone
Scalability & Per...

Comments

@hongyuchen1030
Copy link
Contributor

Describe the feature you'd like added to this project
Enable node_xyz_to_lonlat_rad, node_lonlat_rad_to_xyz, normalize_in_place take np.array() as input and output

Link to original functionality implementation elsewhere, if applicable
Originigaly:

  1. It only takes list as input and the output is also list
    Links to other examples, if applicable

Describe the solution you'd like
Modify the current node_xyz_to_lonlat_rad, node_lonlat_rad_to_xyz, normalize_in_place helper functions
such that: 1. it takes np.array() or list as input. 2. The output is in the np.array() format

Additional context
Add any other context or screenshots about the feature request here.
@hongyuchen1030 hongyuchen1030 added the new feature New feature or request label Jun 14, 2023
@hongyuchen1030 hongyuchen1030 self-assigned this Jun 14, 2023
@hongyuchen1030 hongyuchen1030 mentioned this issue Jun 14, 2023
Closed
@hongyuchen1030 hongyuchen1030 mentioned this issue Jun 23, 2023
Merged
10 tasks
@erogluorhan erogluorhan changed the title Node 2D/3D Coordinates Conversion Overloaded with Numpy.ndArray Support Numpy.ndArray for Node 2D/3D Coordinate Conversion Functions Aug 22, 2023
@philipc2 philipc2 linked a pull request Oct 25, 2023 that will close this issue
DRAFT: Vectorize & Optimize Coordinate Conversion Functions #546
Closed
14 tasks
rajeeja added a commit that referenced this issue Oct 25, 2023
@rajeeja
o Address issue #146 #346
e4226b9
@erogluorhan erogluorhan added dependencies Pull requests that update a dependency file improvement Improvements on existing features or infrastructure and removed new feature New feature or request labels Oct 25, 2023
@rajeeja rajeeja mentioned this issue Oct 27, 2023
Closed
14 tasks
@hongyuchen1030 hongyuchen1030 added this to the Core - Grid milestone Oct 27, 2023
@philipc2 philipc2 removed a link to a pull request Mar 19, 2024
DRAFT: Vectorize & Optimize Coordinate Conversion Functions #546
Closed
14 tasks
@philipc2 philipc2 mentioned this issue Mar 27, 2024
Closed
@erogluorhan erogluorhan mentioned this issue Mar 27, 2024
Merged
@philipc2 philipc2 mentioned this issue Apr 3, 2024
Merged
@erogluorhan erogluorhan mentioned this issue Apr 3, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rajeeja rajeeja

@philipc2 philipc2

@hongyuchen1030 hongyuchen1030

Labels
dependencies Pull requests that update a dependency file improvement Improvements on existing features or infrastructure
Projects
UXarray Development
Status: ✅ Done
Milestone
Scalability & Performance
Development

Successfully merging a pull request may close this issue.

Vectorize Coordinate Conversion Functions UXARRAY/uxarray
4 participants
@rajeeja @erogluorhan @philipc2 @hongyuchen1030