-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Point on GCA helper function #357
Merged
hongyuchen1030
merged 40 commits into
UXARRAY:main
from
hongyuchen1030:point_on_GCR_helper_function
Aug 14, 2023
Merged
Point on GCA helper function #357
hongyuchen1030
merged 40 commits into
UXARRAY:main
from
hongyuchen1030:point_on_GCR_helper_function
Aug 14, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Can you untrack all the files under |
You mean deleting all lines after |
…gyuchen1030/uxarray into point_on_GCR_helper_function
…gyuchen1030/uxarray into point_on_GCR_helper_function
philipc2
requested changes
Jul 9, 2023
philipc2
approved these changes
Jul 20, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
philipc2
reviewed
Aug 8, 2023
philipc2
reviewed
Aug 8, 2023
…nging everything to numpy will require more changes
rajeeja
requested changes
Aug 9, 2023
This reverts commit e2c1eb7. revert the wrong overwritten#
Revert "Fix Pr UXARRAY#357"
Revert "Revert "Fix Pr UXARRAY#357""
rajeeja
requested changes
Aug 10, 2023
rajeeja
approved these changes
Aug 10, 2023
philipc2
reviewed
Aug 10, 2023
philipc2
reviewed
Aug 10, 2023
Co-authored-by: Philip Chmielowiec <[email protected]>
…to point_on_GCR_helper_function # Conflicts: # uxarray/grid/lines.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #356 #312
Overview
a feature that determines whether a given point lies within a great circle arc. The great circle arc should be restricted to a span of less than 180 degrees, and the implementation should handle cases where the arc crosses the antimeridian (the 0-degree meridian).
And a global error tolerance constant described in #312 is set
Expected Usage
PR Checklist
General
Testing
Documentation
_
) and have been added todocs/internal_api/index.rst
docs/user_api/index.rst