-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DRAFT: Vectorize & Optimize Coordinate Conversion Functions #546
Conversation
@@ -83,40 +88,75 @@ def node_xyz_to_lonlat_rad(node_coord): | |||
return [d_lon_rad, d_lat_rad] | |||
|
|||
|
|||
@njit(cache=ENABLE_JIT_CACHE) | |||
def normalize_in_place(node): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is another issue #346 where the requirement is node
be a numpy array. It'd be good to tackle both together. It has to be done carefully as it breaks numba compatibility.
uxarray/grid/coordinates.py
Outdated
#@njit(cache=ENABLE_JIT_CACHE) | ||
def normalize_in_place(coords): | ||
|
||
coords_norm = coords / np.linalg.norm(coords, ord=2, axis=1) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have started a branch with similar WIP code - here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll take a look at this! This branch right here is just a few ideas tossed together for now :)
Closing this PR as it's become stale, will revisit the implementation in a new PR |
Closes #XXX
Overview
Expected Usage
PR Checklist
General
Testing
Documentation
_
) and have been added todocs/internal_api/index.rst
docs/user_api/index.rst
Examples
docs/examples/
folderdocs/examples.rst
toctreedocs/gallery.yml
with appropriate thumbnail photo indocs/_static/thumbnails/