Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regenerate Manifest.toml with Julia 1.9.2 #394

Merged
merged 16 commits into from
Jul 10, 2023
Merged

Regenerate Manifest.toml with Julia 1.9.2 #394

merged 16 commits into from
Jul 10, 2023

Conversation

devmotion
Copy link
Member

@devmotion devmotion commented Jun 23, 2023

Update of #379, let's see how many tutorials are (not) broken.

Broken/assertions fail:

Fixes #378.

@devmotion devmotion marked this pull request as draft June 24, 2023 05:39
@devmotion devmotion changed the title Regenerate Manifest.toml with Julia 1.9.1 Regenerate Manifest.toml with Julia 1.9.2 Jul 7, 2023
@devmotion
Copy link
Member Author

@torfjelde The PR is almost ready but I won't be able to finish it today. It seems the VI tutorial has to be updated due to the recent changes in Bijectors - if you want, you can have a look what's the issue and push a fix. Otherwise I'll check it tomorrow.

The time series tutorial I have to run locally to see whether it's an actual problem or we just have to adjust the assertion.

Generally, in case JuliaArrays/FillArrays.jl#273 is merged and released soon, it would be nice to wait for it to avoid having to set FillArrays to 1.0.0 in the tutorials explicitly (otherwise Turing will be downgraded if you try to update the Manifest files). This would also allow us to benefit from some fixes and performance improvements in more recent FillArrays versions.

@devmotion devmotion marked this pull request as ready for review July 8, 2023 20:39
@torfjelde
Copy link
Member

Awesome! I'll have a look at the Bijectors stuff 👍

@devmotion
Copy link
Member Author

@torfjelde I fixed the VI tutorial, seems to run fine now.

@devmotion devmotion requested review from yebai and torfjelde July 10, 2023 13:30
@devmotion
Copy link
Member Author

Once you are fine with the changes, @yebai and @torfjelde, we have to update the buildkite hashes before merging the PR (currently I have to unblock manually every buildkite run). Actually I can't do that but I'll ping Elliot.

Copy link
Member

@torfjelde torfjelde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome stuff @devmotion ❤️

@devmotion
Copy link
Member Author

@staticfloat can you please regenerate the keys? I switched from Julia 1.6 to 1 in this PR since the latest Turing releases don't support Julia < 1.7 🙂

@devmotion
Copy link
Member Author

Thank you @staticfloat 🙂

@devmotion devmotion merged commit a85147f into master Jul 10, 2023
@delete-merged-branch delete-merged-branch bot deleted the dw/julia_1-9-1 branch July 10, 2023 22:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reproducibility between Julia < 1.7 and >= 1.7
4 participants