Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable typescript strict mode #2126

Merged
merged 8 commits into from
Jun 23, 2021
Merged

Enable typescript strict mode #2126

merged 8 commits into from
Jun 23, 2021

Conversation

mfedderly
Copy link
Collaborator

No description provided.

@mfedderly mfedderly requested a review from JamesLMilner June 23, 2021 11:43
@JamesLMilner
Copy link
Collaborator

@mfedderly what do you think about turning strict: true on in all the tsconfig.json files across the repo? That would actually ensure we are always strictly enabled going forward

@mfedderly
Copy link
Collaborator Author

All of the individual packages have this tsconfig:

{
  "extends": "../../tsconfig.shared.json",
  "compilerOptions": {
    "outDir": "dist/js"
  },
  "files": ["index.ts"]
}

By changing tsconfig.shared.json we change them all to enforce strict mode.

@JamesLMilner
Copy link
Collaborator

All of the individual packages have this tsconfig:

{
  "extends": "../../tsconfig.shared.json",
  "compilerOptions": {
    "outDir": "dist/js"
  },
  "files": ["index.ts"]
}

By changing tsconfig.shared.json we change them all to enforce strict mode.

Sorry, yes I missed this! Looks good :)

@mfedderly
Copy link
Collaborator Author

@JamesLMilner can you add the github approval so I can merge this later? Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants