Fix TypeScript strict mode typing errors for turf-polygonize and turf-clusters-dbscan #2109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JamesLMilner
commented
Jun 20, 2021
| @@ -205,7 +207,7 @@ export default class Graph { | |||
|
|
|||
| if (de.label === label) outDE = de; | |||
|
|
|||
| if (sym.label === label) inDE = sym; | |||
| if (((sym as Edge).label as number) === label) inDE = sym; | |||
There was a problem hiding this comment.
I really don't like using as across the code here but I wanted to change the logic as little as possible whilst still fixing the TypeScript issues
JamesLMilner
changed the title
JamesLMilner
force-pushed
the
typescript-clusters-polygonize
branch
from
1afb200 to
fd85627
Compare
|
Favour #2126 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please fill in this template.
npm testat the sub modules where changes have occurred.npm run lintto ensure code style at the turf module level.Fixes TypeScript errors in the
turf-polygonizeandturf-clusters-dbscanpackages. This should resolve the issue people were seeing with turf-dbscan on install when they have TypeScript strict mode on in their project (#2017)