-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Gpu refactor #96
Gpu refactor #96
Conversation
Codecov Report
@@ Coverage Diff @@
## master #96 +/- ##
==========================================
- Coverage 70.19% 68.49% -1.70%
==========================================
Files 39 39
Lines 3214 3276 +62
==========================================
- Hits 2256 2244 -12
- Misses 958 1032 +74
Continue to review full report at Codecov.
|
LightGraphs.jl is archived and no longer mainted, replaced by Graphs
each epoch faster, but for fastest version the paramters don't improve as fast
The tests are passing (both on github actions and on gpu)
Breaking Changes:
Removal of
use_gpu
, if want a query to be run on gpu then need to move the data to gpu first. Now juice decides between where to run based on where the data is. This avoids accidently moving stuff between cpu/gpu all the time.Removal of
use_sample_weights
: did not seem necessary as you can checkisweighted(data)
(already done in the code logic, seemed redundant)Rename
uniform_parameters
touniform_parameters!
as its changing the circuit parameters.rename
estimate_paramters_em
to something likeestimate_paramters_em!
rename
estimate_parameters_cached!
to eupdate_pc_paramters_from_pbc!
rename
estimate_parameters
toestimate_parameters!
Few other renames to add
!
indicating changeNon-breaking changes:
balance_threads_2d
. For example, see the implementation offunction marginal_layers(...
estimate_parameters_em_multi_epochs!