Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove use_gpu when data is available #73

Closed
guyvdbroeck opened this issue Apr 17, 2021 · 1 comment · Fixed by #96
Closed

Remove use_gpu when data is available #73

guyvdbroeck opened this issue Apr 17, 2021 · 1 comment · Fixed by #96
Assignees

Comments

@guyvdbroeck
Copy link
Member

We currently need to synchronize between the device used for the bitcircuit, the data, and often a use_gpu flag. Standardize on always using isgpu(data) for this decision whenever the data is available; move the bitcircuit to the same device as the data, and remove the use_gpu flag. Don't repeat infrastructure to move things to the GPU, assume the outside user makes that decision by saying togpu(data) or not.

@khosravipasha
Copy link
Contributor

Also related, we are using reuse for resuing memory for different batches, but not across epochs, might be good to change the high level API to make it easy to do.

@khosravipasha khosravipasha linked a pull request Nov 4, 2021 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants