Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Breaking: New version of SimpleWeightedGraphs v1.2 #93

Closed
khosravipasha opened this issue Oct 19, 2021 · 1 comment · Fixed by #96
Closed

Breaking: New version of SimpleWeightedGraphs v1.2 #93

khosravipasha opened this issue Oct 19, 2021 · 1 comment · Fixed by #96

Comments

@khosravipasha
Copy link
Contributor

Fixing it to the older versrion for now.
SimpleWeightedGraphs = "~1.1"

$ julia --project=test test/structurelearner/chow_liu_tree_tests.jl 

learn chow-liu tree tests: Error During Test at /space/pashak/.julia/dev/ProbabilisticCircuits/test/structurelearner/chow_liu_tree_tests.jl:9
  Got exception outside of a @test
  MethodError: no method matching SimpleWeightedGraphs.SimpleWeightedGraph(::SimpleGraph{Int64})
  Closest candidates are:
    SimpleWeightedGraphs.SimpleWeightedGraph() at /home/pashak/.julia/packages/SimpleWeightedGraphs/W7kue/src/simpleweightedgraph.jl:49
    SimpleWeightedGraphs.SimpleWeightedGraph(::SparseArrays.SparseMatrixCSC{U, T}) where {T<:Integer, U<:Real} at /home/pashak/.julia/packages/SimpleWeightedGraphs/W7kue/src/simpleweightedgraph.jl:26
    SimpleWeightedGraphs.SimpleWeightedGraph(::AbstractVector{T}, ::AbstractVector{T}, ::AbstractVector{U}; combine) where {T<:Integer, U<:Real} at /home/pashak/.julia/packages/SimpleWeightedGraphs/W7kue/src/simpleweightedgraph.jl:94
    ...
  Stacktrace:
   [1] learn_chow_liu_tree(train_x::DataFrame; α::Float64, clt_root::String, weight::Vector{Float64})
     @ ProbabilisticCircuits ~/.julia/packages/ProbabilisticCircuits/1xcPJ/src/structurelearner/chow_liu_tree.jl:28
   [2] macro expansion
     @ /space/pashak/.julia/dev/ProbabilisticCircuits/test/structurelearner/chow_liu_tree_tests.jl:47 [inlined]
   [3] macro expansion
     @ /buildworker/worker/package_linux64/build/usr/share/julia/stdlib/v1.6/Test/src/Test.jl:1151 [inlined]
   [4] top-level scope
     @ /space/pashak/.julia/dev/ProbabilisticCircuits/test/structurelearner/chow_liu_tree_tests.jl:10
   [5] include(mod::Module, _path::String)
     @ Base ./Base.jl:386
   [6] exec_options(opts::Base.JLOptions)
     @ Base ./client.jl:285
   [7] _start()
     @ Base ./client.jl:485
Test Summary:             | Pass  Error  Total
learn chow-liu tree tests |    1      1      2
ERROR: LoadError: Some tests did not pass: 1 passed, 0 failed, 1 errored, 0 broken.
@simonschoelly
Copy link

Yes, sorry about that, I was a bit careless with semantic version for SimpleWeightedGraphs The reason is, that development moved from LightGraphs to Graphs.jl.

I would recommend you to switch to Graphs.jl too and increase the version of SimpleWeightedGraphs to 1.2.

@khosravipasha khosravipasha linked a pull request Nov 3, 2021 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants