This repository has been archived by the owner on Jan 9, 2024. It is now read-only.
Wip api adjustments #94
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some things still need to be tested throughout. But it works for my app and I think this could be a good starting point to make the library work again.
Fixed a bug that prevented the correct parsing of some JSON objects. Added a try-catch in the removeHtml function.
It was preventing to correctly show some files that didn't feature a short description
I made the code compatible with the latest data return
Co-authored-by: TimeForANinja <[email protected]>
Fix unable to find JSON
* use options#requestOptions to pass to miniget * return continuation information * expose parsePage2 as ytpl#continue * add type-checks for ytpl#continue
TimeForANinja
force-pushed
the
wip-api-adjustments
branch
from
3fb8ec7 to
91e1d4e
Compare
* continuation errors when limit=Infinity which is the default provided by a regular request
* Fix playlist URL * Make it simple Co-authored-by: TimeForANinja <[email protected]>
Co-Authored-By: patrickkfkan <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
todo before merging
fix requests
update exaple responses
update typings
update documentation / README
rewrite tests
closes #72
closes #83
closes #84
closes #100
Porting code
options#requestOptionspageswas added as a more request-efficient alternative tolimitplaylist#visibility#link_onlywas renamed tounlistedImagefeaturingurl,widthandheightproperties - arrays of images are always sorted by descending resolutionreftourlto keep it consistend across all librariesresponse#result_itemsis nowresponse#estimatedItemCountchannelIDas well as a canonicalurl