Skip to content
This repository has been archived by the owner on Jan 9, 2024. It is now read-only.

move request options to requestOptions parameter #83

Closed
TimeForANinja opened this issue Nov 8, 2020 · 0 comments · Fixed by #94
Closed

move request options to requestOptions parameter #83

TimeForANinja opened this issue Nov 8, 2020 · 0 comments · Fixed by #94
Labels
enhancement

Comments

@TimeForANinja
Copy link
Owner

instead of sth like

ytpl('xxxx', { agent: xxx });

use sth like this:

ytpl('xxxx', { requestOptions: { agent: xxx }});

to comply with ytdl-core
@TimeForANinja TimeForANinja mentioned this issue Dec 11, 2020
Merged
5 tasks
TimeForANinja added a commit that referenced this issue Dec 13, 2020
@TimeForANinja
Rewrite to adjust for new Webpage
eabca3c 
- [x] fix requests

- [x] update exaple responses

- [x] update typings

- [x] update documentation / README

- [x] rewrite tests

closes #72 
closes #83 
closes #84 
closes #100 

# Porting code
* request options for miniget were moved to `options#requestOptions`
* nextpageRef was replaced by the continuation feature => check the README for more information
*  `pages` was added as a more request-efficient alternative to `limit`
* `playlist#visibility#link_only` was renamed to `unlisted`
* all thumbnails are now Objects of type `Image` featuring `url`, `width` and `height` properties - arrays of images are always sorted by descending resolution
* all links have been renamed from `ref` to `url` to keep it consistend across all libraries
* all snake_case variables were replaced by CamelCase
* `response#result_items` is now `response#estimatedItemCount`
* all users/channels feature both the `channelID` as well as a canonical `url`
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Wip api adjustments TimeForANinja/node-ytpl
1 participant
@TimeForANinja