Skip to content
This repository has been archived by the owner on Jan 9, 2024. It is now read-only.

(wip) 'Favorites' playlist not recognized #100

Closed
patrickkfkan opened this issue Dec 12, 2020 · 1 comment · Fixed by #94
Closed

(wip) 'Favorites' playlist not recognized #100

patrickkfkan opened this issue Dec 12, 2020 · 1 comment · Fixed by #94

Comments

@patrickkfkan
Copy link
Contributor

patrickkfkan commented Dec 12, 2020

Hello,

Me again ^_^

I found that ID of Favorite-type playlists start with 'FL' and so does not get recognized by ytpl.

I'm not sure if all 'Favorites' playlists start with 'FL', though. I just came across this in this channel.

To get playlist IDs starting with 'FL to load', I changed this line in main.js:

const PLAYLIST_REGEX = exports.PLAYLIST_REGEX = /^(PL|UU|LL|RD)[a-zA-Z0-9-_]{16,41}$/;

to this:

const PLAYLIST_REGEX = exports.PLAYLIST_REGEX = /^(FL|PL|UU|LL|RD)[a-zA-Z0-9-_]{16,41}$/;

ytpl is able to load the playlist afterwards.

-Patrick

@TimeForANinja
Copy link
Owner

🤔 i knew about WL for Watch Later but ignored them since they are always private

guess there's no reason to not support FL-Playlists
nice spotting, will add support & tests later today 👍🏻

@TimeForANinja TimeForANinja mentioned this issue Dec 12, 2020
5 tasks
TimeForANinja added a commit that referenced this issue Dec 13, 2020
- [x] fix requests

- [x] update exaple responses

- [x] update typings

- [x] update documentation / README

- [x] rewrite tests

closes #72 
closes #83 
closes #84 
closes #100 

# Porting code
* request options for miniget were moved to `options#requestOptions`
* nextpageRef was replaced by the continuation feature => check the README for more information
*  `pages` was added as a more request-efficient alternative to `limit`
* `playlist#visibility#link_only` was renamed to `unlisted`
* all thumbnails are now Objects of type `Image` featuring `url`, `width` and `height` properties - arrays of images are always sorted by descending resolution
* all links have been renamed from `ref` to `url` to keep it consistend across all libraries
* all snake_case variables were replaced by CamelCase
* `response#result_items` is now `response#estimatedItemCount`
* all users/channels feature both the `channelID` as well as a canonical `url`
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants