Bug fix: schema evolution fix-to-var reads #5321
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bekadavis9
force-pushed
the
rd/bugfix-schema_evolution-fixed_to_var
branch
from
196180f to
c4a4d76
Compare
ihnorton
approved these changes
Oct 7, 2024
bekadavis9
added a commit
that referenced
this pull request
Nov 12, 2024
Schema evolution bug fix: Reads no longer fail after dropping a fixed attribute and adding it back as var-sized. Followup to #5321 to address a previously-missed case caught by [TileDB-Inc/TileDB-Py/#2083](TileDB-Inc/TileDB-Py#2083) [sc-55085] --- TYPE: BUG DESC: Schema evolution bug fix: Reads no longer fail after dropping a fixed attribute and adding it back as var-sized, part 2.
Comment on lines
871
to
883
| // Read the array | ||
| std::string buffer; | ||
| std::vector<uint64_t> offsets = {1, 2, 3, 4, 5, 6, 7, 8, 9, 10}; | ||
| std::vector<uint64_t> offsets(10); | ||
| Array array_r(ctx, array_uri, TILEDB_READ); | ||
| Subarray subarray(ctx, array_r); | ||
| subarray.add_range(0, 1, 10); | ||
| Subarray subarray_r(ctx, array_r); | ||
| subarray_r.add_range(0, 1, 10); | ||
| Query query_r(ctx, array_r, TILEDB_READ); | ||
| query_r.set_layout(layout) | ||
| .set_subarray(subarray) | ||
| .set_subarray(subarray_r) | ||
| .set_data_buffer("a", buffer) | ||
| .set_offsets_buffer("a", offsets); | ||
| query_r.submit(); | ||
| array_r.close(); |
There was a problem hiding this comment.
Should we CHECK something here?
There was a problem hiding this comment.
CHECK(buffer.size() == 0) and CHECK(offsets.size() == 10) work.
Should we add them?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Schema evolution bug fix: Reads no longer fail after dropping a fixed attribute and adding it back as var-sized.
[sc-55085]
TYPE: BUG
DESC: Schema evolution bug fix: Reads no longer fail after dropping a fixed attribute and adding it back as var-sized.