[Backport release-2.2] Add test and fix mutex errors on Windows #2083
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
* Add test for array open and free with invalid URI * sm::array_open_for_reads: fetch fragments async instead of schema Invert the tasking order for async loading established in #2061 Now load the fragments in a task and array schema on main. Fixes several mutex ownership issues which surfaced on Windows. (1) We need to wait on the async task in all return clauses to avoid the following situation which causes an exit on Windows: if the context owning the storage manager is destroyed without joining the async thread, then we get an error on Windows due to attempting to destruct a locked mutex. (2) We cannot call open_array->mtx_unlock() on the main thread after running the array_open call async on the thread pool (which locks the open_array.mtx_), because lock/unlock on different threads is undefined behavior and a runtime error on windows.
Shelnutt2
approved these changes
Feb 8, 2021
bekadavis9
added a commit
that referenced
this pull request
Nov 12, 2024
Schema evolution bug fix: Reads no longer fail after dropping a fixed attribute and adding it back as var-sized. Followup to #5321 to address a previously-missed case caught by [TileDB-Inc/TileDB-Py/#2083](TileDB-Inc/TileDB-Py#2083) [sc-55085] --- TYPE: BUG DESC: Schema evolution bug fix: Reads no longer fail after dropping a fixed attribute and adding it back as var-sized, part 2.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport a168cca from #2077