Add test for dropping a fixed attribute and adding it back as var-sized #2083
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kounelisagis
changed the title
ihnorton
reviewed
Oct 12, 2024
kounelisagis
force-pushed
the
agis/schema-evolution-fixed-to-var
branch
2 times, most recently
from
5293c1f to
0b1c770
Compare
kounelisagis
changed the title
kounelisagis
force-pushed
the
agis/schema-evolution-fixed-to-var
branch
from
0b1c770 to
c42cd91
Compare
kounelisagis
force-pushed
the
agis/schema-evolution-fixed-to-var
branch
from
c62b9b8 to
cae6ff3
Compare
bekadavis9
added a commit
to TileDB-Inc/TileDB
that referenced
this pull request
Nov 12, 2024
Schema evolution bug fix: Reads no longer fail after dropping a fixed attribute and adding it back as var-sized. Followup to #5321 to address a previously-missed case caught by [TileDB-Inc/TileDB-Py/#2083](TileDB-Inc/TileDB-Py#2083) [sc-55085] --- TYPE: BUG DESC: Schema evolution bug fix: Reads no longer fail after dropping a fixed attribute and adding it back as var-sized, part 2.
bekadavis9
reviewed
Nov 12, 2024
ihnorton
approved these changes
Nov 14, 2024
There was a problem hiding this comment.
LGTM after addressing the fill value check request from @bekadavis9
kounelisagis
added a commit
that referenced
this pull request
Nov 29, 2024
kounelisagis
added a commit
that referenced
this pull request
Nov 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following TileDB-Inc/TileDB#5321 and TileDB-Inc/TileDB#5362, let's add a TileDB-Py test.
[sc-57039]