Install req'd nanoarrow for valgrind nightlies, also install arrow #664
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also fix a minor bug noticed today
eddelbuettel
requested review from
ihnorton,
aaronwolen,
awenocur and
mojaveazure
|
This pull request has been linked to Shortcut Story #42457: Maintenance for nightlies. |
mojaveazure
approved these changes
Mar 4, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The recent PR #663 makes
nanoarrowa requirement. But the older of the two nightlies still uses an explicit package list which did not include it. As we rely on easy to install binaries, we addarrowas (which is only aSuggests:) to widen the test coverage.Also fix a minor 'style bug' noticed today in one VFS function.