Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install req'd nanoarrow for valgrind nightlies, also install arrow #664

Merged
merged 2 commits into from
Mar 4, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion DESCRIPTION
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
Package: tiledb
Type: Package
Version: 0.24.0.3
Version: 0.24.0.4
Title: Modern Database Engine for Multi-Modal Data via Sparse and Dense Multidimensional Arrays
Authors@R: c(person("TileDB, Inc.", role = c("aut", "cph")),
person("Dirk", "Eddelbuettel", email = "[email protected]", role = "cre"))
Expand Down
2 changes: 2 additions & 0 deletions NEWS.md
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,8 @@

* The `tiledb_get_query_range_var()` accessor now correctly calls the range getter for variable-sized dimensions (#662)

* The nighly valgrind check now installs to require `nanoarrow` package (#664)


# tiledb 0.24.0

Expand Down
3 changes: 1 addition & 2 deletions src/libtiledb.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -4376,8 +4376,7 @@ std::string libtiledb_vfs_create_dir(XPtr<tiledb::VFS> vfs, std::string uri) {
// [[Rcpp::export]]
bool libtiledb_vfs_is_dir(XPtr<tiledb::VFS> vfs, std::string uri) {
check_xptr_tag<tiledb::VFS>(vfs);
auto ptr = vfs.get();
return ptr->is_dir(uri);
return vfs->is_dir(uri);
}

// [[Rcpp::export]]
Expand Down
2 changes: 2 additions & 0 deletions tools/ci/valgrind/installDependencies.sh
Original file line number Diff line number Diff line change
Expand Up @@ -74,11 +74,13 @@ echo "::endgroup::"
echo "::group::Install R Packages"
# This relies on bspm and installs binaries (i.e. r-cran-* packages)
install.r \
arrow \
bit64 \
curl \
data.table \
Matrix \
nanotime \
nanoarrow \
nycflights13 \
palmerpenguins \
Rcpp \
Expand Down