Install req'd nanoarrow for valgrind nightlies, also install arrow (#664

) * Install req'd nanoarrow for valgrind nightlies, also install arrow Also fix a minor bug noticed today * Update NEWS, roll micro version [ci skip]
TileDB-Inc · Mar 4, 2024 · f36409e · f36409e
1 parent f6d12eb
commit f36409e
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 3 deletions.
diff --git a/DESCRIPTION b/DESCRIPTION
@@ -1,6 +1,6 @@
 Package: tiledb
 Type: Package
-Version: 0.24.0.3
+Version: 0.24.0.4
 Title: Modern Database Engine for Multi-Modal Data via Sparse and Dense Multidimensional Arrays
 Authors@R: c(person("TileDB, Inc.", role = c("aut", "cph")),
  person("Dirk", "Eddelbuettel", email = "[email protected]", role = "cre"))

diff --git a/NEWS.md b/NEWS.md
@@ -10,6 +10,8 @@
 
 * The `tiledb_get_query_range_var()` accessor now correctly calls the range getter for variable-sized dimensions (#662)
 
+* The nighly valgrind check now installs to require `nanoarrow` package (#664)
+
 
 # tiledb 0.24.0
 

diff --git a/src/libtiledb.cpp b/src/libtiledb.cpp
@@ -4376,8 +4376,7 @@ std::string libtiledb_vfs_create_dir(XPtr<tiledb::VFS> vfs, std::string uri) {
 // [[Rcpp::export]]
 bool libtiledb_vfs_is_dir(XPtr<tiledb::VFS> vfs, std::string uri) {
     check_xptr_tag<tiledb::VFS>(vfs);
-    auto ptr = vfs.get();
-    return ptr->is_dir(uri);
+    return vfs->is_dir(uri);
 }
 
 // [[Rcpp::export]]

diff --git a/tools/ci/valgrind/installDependencies.sh b/tools/ci/valgrind/installDependencies.sh
@@ -74,11 +74,13 @@ echo "::endgroup::"
 echo "::group::Install R Packages"
 # This relies on bspm and installs binaries (i.e. r-cran-* packages)
 install.r \
+    arrow \
     bit64 \
     curl \
     data.table \
     Matrix \
     nanotime \
+    nanoarrow \
     nycflights13 \
     palmerpenguins \
     Rcpp \
Original file line number	Diff line number	Diff line change
Expand Up		@@ -10,6 +10,8 @@

		* The `tiledb_get_query_range_var()` accessor now correctly calls the range getter for variable-sized dimensions (#662)

		* The nighly valgrind check now installs to require `nanoarrow` package (#664)


		# tiledb 0.24.0

Expand Down