You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Related to #1188, it seems that Button has a method for validating variants but the code is never used. As seen in #1188 it's possible for someone -- especially if they're not making use of type checking -- to accidentally set a variant that may have an unintended consequence (see the disabled example in the other issue).
Should validate_variant be put to use and an exception be thrown if an unsupported variant is set by the caller?
The text was updated successfully, but these errors were encountered:
Related to #1188, it seems that
Button
has a method for validating variants but the code is never used. As seen in #1188 it's possible for someone -- especially if they're not making use of type checking -- to accidentally set a variant that may have an unintended consequence (see thedisabled
example in the other issue).Should
validate_variant
be put to use and an exception be thrown if an unsupported variant is set by the caller?The text was updated successfully, but these errors were encountered: