Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check button variant for validity during button construction #1195

Merged
merged 1 commit into from
Nov 16, 2022
Merged

Check button variant for validity during button construction #1195

merged 1 commit into from
Nov 16, 2022

Conversation

davep
Copy link
Contributor

@davep davep commented Nov 16, 2022

See #1189

@davep davep linked an issue Nov 16, 2022 that may be closed by this pull request
Should Button variants be runtime validated? #1189
Closed
@willmcgugan willmcgugan merged commit 572d9b6 into Textualize:main Nov 16, 2022
@davep davep deleted the button-variant-check branch November 16, 2022 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@willmcgugan willmcgugan willmcgugan approved these changes

@rodrigogiraoserrao rodrigogiraoserrao Awaiting requested review from rodrigogiraoserrao

@darrenburns darrenburns Awaiting requested review from darrenburns

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Should Button variants be runtime validated?
2 participants
@davep @willmcgugan