Check button variant for validity during button construction

See Textualize#1189
davep · Nov 16, 2022 · e3899c0 · e3899c0
1 parent a465f5c
commit e3899c0
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -30,6 +30,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/).
 
 - Watchers are now called immediately when setting the attribute if they are synchronous. https://github.com/Textualize/textual/pull/1145
 - Widget.call_later has been renamed to Widget.call_after_refresh.
+- Button variant values are now checked at runtime. https://github.com/Textualize/textual/issues/1189
 
 ### Fixed
 

diff --git a/src/textual/widgets/_button.py b/src/textual/widgets/_button.py
@@ -186,7 +186,7 @@ def __init__(
         if disabled:
             self.add_class("-disabled")
 
-        self.variant = variant
+        self.variant = self.validate_variant(variant)
 
     label: Reactive[RenderableType] = Reactive("")
     variant = Reactive.init("default")